-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-02-02] Manage members: Opacity reduces pressing on the workspace admin #13769
Comments
I would say that this might be a bug, but it's weird that you can select it as well. |
I will post on the ope source channel about this, but I would adivise either not show the user, or not be selectable (this includes hiding the checkbox for this users) |
So it was decided that just disabling the opacity for the admins was enough as we already show an error on mobile and a tip on desktop and web. |
@sketchydroide sounds like you're going to make the fix so I'm going to add the internal label. |
it's a bit more complex than that actually, but for now that sounds good. |
@JmillsExpensify do you think this should still be a bug atm? I feel there is a bug, still, but kinda maybe a feature as well, as we might use similar patterns elsewhere or in the future. CCing @Puneet-here and @luacmartins as you might have some input on this |
I think it is a bug, but I think it's one of those bugs where solving it requires a broader plan, so we need a process to figure out how to handle these. Like reliable notifications or sequence numbers, they don't fit in WAQ. Perhaps for now we remove any issue with the |
yep I think that would make sense, specially since they take way more time to be finished. @luacmartins I think you should be back from OOO let me know your thoughts on this (not sure if you know anything, but your knowledge of forms would probably help) |
Left a comment in the thread |
Your input on the thread sounds good, I think I can do something about it.
I will updat this GH to better exlpain the issue and the solution |
I might be able to work on it this week if not I'll let someone else pick it up as I'm going OOO after tomorrow for a week |
@sketchydroide should we look for a volunteer in Slack or could we add the |
I see that @sketchydroide is ooo. I'll take this over until he's back. |
Gonna work on this tomorrow! |
PR up |
Thanks for picking this up @luacmartins |
PR merged! Waiting on deploys! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.59-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-02-02. 🎊 After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
This wasn't really a bug. It's an UX preference so no need to do the checklist |
@tjferriss Gentle reminder. Regression period is passed (2 feb). |
@tjferriss bump for payment! |
Sorry for the delay. The original Upworks post was closed so I've created a new one here:https://www.upwork.com/jobs/~0197b675e1adf982dc @jatinsonijs can you please apply here? |
This comment was marked as resolved.
This comment was marked as resolved.
The offer is pending. Once you accept @jatinsonijs, I can make payment. |
Accepted @tjferriss |
The payment has been made. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Shouldn’t reduce opacity bcz its not a selectable item.
Actual Result:
Opacity reducing like normal active item.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.2.42-2
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Recording.1135.mp4
opacity.mov
Expensify/Expensify Issue URL:
Issue reported by: @jatinsonijs
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1671602565821529
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: