-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-08-28] Initiating a chat with secondary login with which already have a DM shows weird error #15511
Comments
Triggered auto assignment to @puneetlath ( |
Bug0 Triage Checklist (Main S/O)
|
@puneetlath Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Chatting about the ideal behavior here: https://expensify.slack.com/archives/C049HHMV9SM/p1677794822257989?thread_ts=1675355583.321969&cid=C049HHMV9SM |
Behavior has been agreed on. Starting looking into the code. |
@puneetlath this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
@puneetlath Eep! 4 days overdue now. Issues have feelings too... |
Haven't had a chance to dig into this too much with ECX, but hope to later this week. |
Back from ECX. Will dive into this now. |
@puneetlath this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks! |
@puneetlath Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@puneetlath this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks! |
Job added to Upwork: https://www.upwork.com/jobs/~017b41276da6b57d22 |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt ( |
PR is ready for review |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.55-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-08-28. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
I think we can skip the checklist on this one. This is almost more of a new feature than a bug. |
Agreed. Would the regression test be added for this @puneetlath ? |
That's a good idea. Can you propose one? |
I was wondering if the test steps from PR are good? |
@puneetlath Can you post the payout summary here? |
Payment summary:
@mananjadhav please ping me here once you've opened the manual request in NewDot. |
@puneetlath I've raised the payout request on NewDot. |
Reviewed the details for @mananjadhav. $1,000 approved for payment via NewDot based on BZ summary. |
@puneetlath I think we're good to close this one out? |
Yep, all good here. Thanks everyone! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
User should be able to chat with a secondary login
Actual Result:
Report no longer exists error message appears
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.2.
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
az_recorder_20230227_120957.1.mp4
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1675355583321969
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: