[HOLD for payment 2023-05-04] [$1000] Add reaction tooltip is not centered

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any chat
2. Add an emoji reaction to a message
3. Hover over the add reaction button
4. Notice the tooltip is slightly to the right

Expected Result:

The tooltip is on the center

Actual Result:

The tooltip position is slightly to the right

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [] Android / native
• [] Android / Chrome
• [] iOS / native
• [] iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.81-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @bernhardoj
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678355623539929

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0166724d9c139034e8
• Upwork Job ID: 1650631454017658880
• Last Price Increase: 2023-04-24

[MelvinBot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[maddylewis]

@kavimuru - is this in reference to the positioning of this?

[maddylewis]

im not sure this is worth addressing at this time. so im going to close!

[Pujan92]

@stitesExpensify aren't the tooltips for the reaction bubbles should be in center and near/touch the bubbles?

[stitesExpensify]

It probably should be, but we already have some cleanup issues for the Margelo team since we rushed this feature out the door, and it will be taken care of there. Thanks!

[Pujan92]

It probably should be, but we already have some cleanup issues for the Margelo team since we rushed this feature out the door, and it will be taken care of there. Thanks!

Ok, Thanks!

[s77rt]

Hey @stitesExpensify can we reopen this for #17791 (comment)

cc @maddylewis

[stitesExpensify]

Yes, let's go ahead and re-open. We'll fix ALL the bugs!

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0166724d9c139034e8

[MelvinBot]

Current assignee @maddylewis is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Current assignee @stitesExpensify is eligible for the External assigner, not assigning anyone new.

[s77rt]

@stitesExpensify I'm not sure this need a C+ review. This is part of the volunteer process no payment is due here except for the bug reporter (I suppose)

[stitesExpensify]

Ah gotcha, thank you for the correction. Removing you @fedirjh!

[fedirjh]

No problem @s77rt , I will help filling the PR reviewer checklist.

[MahmudjonToraqulov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add reaction tooltip is not centered

What is the root cause of that problem?

The margin-right is causing the problem. The tooltip is centered to its parent element. (more in the video)

What changes do you think we should make in order to solve the problem?

As it's the last element in this range we can feel free to remove margin-right from the last element.

What alternative solutions did you explore? (Optional)

None.

screen-capture.4.webm

[s77rt]

@MahmudjonToraqulov I don't think this is open for proposals. The Help Wanted label was applied by accident 😅. Sorry for the false alert.

@stitesExpensify Please remove Help Wanted label.

[stitesExpensify]

Thanks a lot melvin 🙄 I already removed it once!

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.6-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• emojiReactionBubble style: remove unnecessary margins #17850

If no regressions arise, payment will be issued on 2023-05-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@stitesExpensify] The PR that introduced the bug has been identified. Link to the PR:
• [@stitesExpensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@stitesExpensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@stitesExpensify] Determine if we should create a regression test for this bug.
• [@stitesExpensify] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: