[HOLD for payment 2023-07-17] [$2000] Feature Request: Update header for 6 person DMs to show all avatars

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Problem:

DM members in group chats are capped at a maximum of 4 avatars

Solution:

DMs are capped at 6 members and then add +1 to show more members, Once we get to 5, we use a smaller avatar size

Context/Examples/Screenshots/Notes:

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:
Issue reported by:@puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678715475290659

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c018b3452ff97bbe
• Upwork Job ID: 1635771179154558976
• Last Price Increase: 2023-06-16

[MelvinBot]

Triggered auto assignment to @mateocole (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

[shawnborton]

Looks good to me!

[mateocole]

@shawnborton is this something we will likely be looking at updating internally?

[puneetlath]

This can be done by external contributors.

[mateocole]

got it, in that case going to mark as external

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01c018b3452ff97bbe

[MelvinBot]

Current assignee @mateocole is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[MelvinBot]

Triggered auto assignment to @NikkiWines (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• DMs to show all avatars #21402

If no regressions arise, payment will be issued on 2023-07-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[puneetlath]

Sent @WikusKriek a hiring offer.

@mananjadhav I'm assuming you'll request payment on NewDot when the time comes.

[WikusKriek]

Thanks @puneetlath, just one question regarding the bounty. I see the offer is still 2k but it should it not have been doubled as stated here?

[puneetlath]

Thanks for reminding me @WikusKriek. I added a second milestone to the contract to account for that.

[mananjadhav]

@puneetlath I've requested the payment via NewDot.

[mananjadhav]

@puneetlath Just checking here, with the updated scope we didn't explicitly discuss/decide on the timeline bonus. Overall with both the changes the PR took ~7 days (excluding weekends).

and also that we double the payment, instead of increasing by $1K, so might consider that as the bonus?

[anmurali]

@puneetlath can you confirm ^^ makes sense. I need to approve and pay this on New Dot

[melvin-bot]

@puneetlath, @shawnborton, @mananjadhav, @WikusKriek Whoops! This issue is 2 days overdue. Let's get this updated quick!

[puneetlath]

It should be $4k in total @anmurali. It was a $2k job and we doubled the scope, so it became $4k. No timeline bonus.

I just paid out @WikusKriek that amount in Upwork so @mananjadhav just needs to be paid that as well.

[puneetlath]

It should be $4k in total @anmurali. It was a $2k job and we doubled the scope, so it became $4k. No timeline bonus.

I just paid out @WikusKriek that amount in Upwork so @mananjadhav just needs to be paid that as well.

[anmurali]

Approved to Manan for $4k

[puneetlath]

Ok great. Closing this out then. Thanks everyone!