[HOLD for payment 2023-07-17] [$250] Migrate index.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/pages/ValidateLoginPage/index.js
  • type: React.Component
  • has state values: false
  • has refs: false
  • has context: false
  • lifecycle methods: componentDidMount

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

[MelvinBot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[marcaaron]

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

[melvin-bot]

@cristipaval Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@cristipaval Still overdue 6 days?! Let's take care of this!

[cristipaval]

Melvin, this one is being reviewed.

[melvin-bot]

@cristipaval Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@cristipaval Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@cristipaval Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot]

@cristipaval 10 days overdue. Is anyone even seeing these? Hello?

[melvin-bot]

This issue has not been updated in over 14 days. @cristipaval eroding to Weekly issue.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Hook refactor for ValidateLoginPage/index.js #19906

If no regressions arise, payment will be issued on 2023-07-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[cristipaval]

Assigning @parasharrajat to be paid for the review.

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[greg-schroeder]

@parasharrajat is in the NewDot payment beta, so I'm going to close this as he will get paid by working directly with Anu. (SO)

[parasharrajat]

Payment Requested 250.

[JmillsExpensify]

@greg-schroeder Can you please summarize the appropriate individual payments for all parties involved in this issue? This is holding up @parasharrajat NewDot payments. More information on this compliance process in Slack.

[greg-schroeder]

@JmillsExpensify There's only one payment.

C+ Review: $250 for @parasharrajat

[JmillsExpensify]

Thanks! I reviewed details for @parasharrajat. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.