-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD PR #17578] Feature Request: Search using Formatted phone numbers like (123) 456-7890 #17255
Comments
Triggered auto assignment to @conorpendergrast ( |
Bug0 Triage Checklist (Main S/O)
|
cc: @puneetlath in case you wanna assign this to yourself |
Oh thanks @rushatgabhane. I'll take it. Do you want to C+ it? |
sure, much appreciated! |
@puneetlath do you think problem 2 is a real problem? Should I raise it on slack for feedback? |
Yeah I'm not convinced about problem 2. But we should definitely solve problem 1. |
After some disucssion on slack, I've removed problem 2 from OP. |
Hi I'm Agata from Callstack - expert contributor group - I'll take this one :) |
Job added to Upwork: https://www.upwork.com/jobs/~016055d98aeee1fd52 |
Current assignee @rushatgabhane is eligible for the Internal assigner, not assigning anyone new. |
Review is ongoing. We're getting close to merging. |
@puneetlath @koko57 could you please tag me in the PR? I wasn't requested a review. Thanks! |
small discussion on what to do with invalid numbers https://expensify.slack.com/archives/C01GTK53T8Q/p1681599809454409 |
Not a ProposalWhat is the root cause of that problem?E/App already support such formatting, something like The regex fails here App/src/libs/OptionsListUtils.js Lines 533 to 534 in f50afdf
We usually strip the input from anything that is not a digit or a plus symbol to match the e164 format but since the regex fail we take the input as is What changes do you think we should make in order to solve the problem?
const parsedPhoneNumber = parsePhoneNumber(LoginUtils.appendCountryCode(searchInputValue));
const searchValue = parsedPhoneNumber.valid ? parsedPhoneNumber.number.e164 : searchInputValue;
return phone.startsWith('+') ? phone : `+${countryCodeByIP}${phone}`; What alternative solutions did you explore? (Optional)None |
I think we are going to do this as a part of #17578. |
@rushatgabhane @puneetlath so it'll be on hold now? |
Ah interesting, yes. It looks like that PR will naturally handle this. I'll put this on hold and we can double-check after that is merged whether this is still needed. |
This issue has not been updated in over 15 days. @puneetlath, @koko57, @rushatgabhane eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
I think we can close this. It's handled already. |
Ah yep. This is done. |
Coming from #16099 (comment)
Problem
When you copy phone numbers from your phone book they have a format (eg:
+1 (123) 456-7890
,+43 123 45 67 89
). Pasting them in our search gives no results :/Solution
Accept formatted numbers in our search component.
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: