[HOLD for payment 2023-08-10] [$1000] When a user clicks on ‘Resend link’, system redirects the user to ‘Get secure link’ page rather than resending new link

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on ‘profile’ avatar
2. Click on ‘Workspace’ link
3. Open an existing ‘Workspace’
4. Click on ‘Issue cards’ link
5. Click on “Connect bank account’ link
6. Click on “Connect manually” link
7. Fill out all forms, and click submit button leading up to “Get secure link” page
8. Click on ‘Get link via SMS’
9. Enter number and click on ‘Send link’ button
10. Click on ‘Resend link’

Expected Result:

System should resend link.

Actual Result:

System didn’t resend link, rather it navigates back to ‘Get secure link’ page.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.0
Reproducible in staging?: y
**Reproducible in production?:**y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.226.mp4

2023-04-07.12.43.00.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680861573856039

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01da05d6ee0cd210a0
• Upwork Job ID: 1651050892927418368
• Last Price Increase: 2023-04-26

[MelvinBot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MariaHCD]

We'll need to escalate this to our CSM at Onfido since it's an issue with the Onfido UI SDK: https://expensify.slack.com/archives/C01SKUP7QR0/p1681323748543949

cc: @michaelhaxhiu

[garrettmknight]

@michaelhaxhiu cool if I assign you here? Seems like you're on this one

[michaelhaxhiu]

Sure thing, I can take it if you need @garrettmknight!

But just to clarify, the link Maria pasted is just a slack thread where I shared that I'm going to get on a call with Onfido to make sure we have a scalable process in place for prioritizing upstream Onfido e/app issues.

Right now, folks are messaging Onfido in an adhoc way to get something prioritized. That may still work but I want to check with Onfido if it's a good plan.

[garrettmknight]

Cool, I'll pass this over to you since you're gonna chat with them anyway. Thanks!

[MelvinBot]

@michaelhaxhiu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

@michaelhaxhiu Still overdue 6 days?! Let's take care of this!

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01da05d6ee0cd210a0

[MelvinBot]

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[MelvinBot]

Triggered auto assignment to @luacmartins (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[michaelhaxhiu]

Ok... this is good for external! We will need to make an Upstream repo fix according to @MariaHCD. Awaiting proposals!

Once that's done, link it here and I'll reach out to Onfido Customer Support to get it prioritized (or the contributor with the chosen proposal can reach out to support). The email is support@onfido.com.

[parasharrajat]

@MariaHCD @michaelhaxhiu I don't think it can be external as the Onfido SDK code is not open source. We will have to raise a ticket with them on this.

[MelvinBot]

@michaelhaxhiu @luacmartins @parasharrajat this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[michaelhaxhiu]

Note: I'm preparing to go OOO for ~2 weeks, and need a BZ buddy to oversee the final payment step while I'm gone so that payment gets sent. cc @Christinadobrzyn

Payment summary:

• Bug reporter $250 @Natnael-Guchima
• C+ PR review $1000 @parasharrajat

[Christinadobrzyn]

@parasharrajat Do we need a regression test?

[parasharrajat]

@Christinadobrzyn No, it was an issue from a third part library and we just upgraded that.

[parasharrajat]

Payment requested.

[Christinadobrzyn]

Created a new Upwork post since the original expired:
Internal posting: https://www.upwork.com/ab/applicants/1689775673325785088/job-details
External posting: https://www.upwork.com/jobs/~01229415642be3f298

Sent an offer to @Natnael-Guchima!

[Nathan-Mulugeta]

I think you accidentally sent the offer to me 😅

[parasharrajat]

@Nathan-Mulugeta feel free to decline.

[Nathan-Mulugeta]

I just declined the offer.

[Christinadobrzyn]

Oh dear, so sorry for the mix up! I just sent an offer to @Natnael-Guchima. Please feel free to accept and I'll pay you.

[Natnael-Guchima]

I have accepted the offer. Thanks @Christinadobrzyn

[Christinadobrzyn]

Paid @Natnael-Guchima!
Closed upwork job
Closing this!

[JmillsExpensify]

Reviewed the details for @parasharrajat. Approved for payment in NewDot based on BZ summary above.