Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due 2023-11-01] Deprecate altool – use notarytool instead #20763

Closed
roryabraham opened this issue Jun 14, 2023 · 7 comments
Closed

[Due 2023-11-01] Deprecate altool – use notarytool instead #20763

roryabraham opened this issue Jun 14, 2023 · 7 comments
Assignees

Comments

@roryabraham
Copy link
Contributor

Coming from https://expensify.slack.com/archives/C07J32337/p1686756113697079

Problem

We are using a deprecated tool for code-signing.

Why this is important

If we don't stop doing this by November 1st then app deploy will stop working.

Solution

  1. Figure out where exactly we're still using altool (it's inside some tool we're using, I don't think we're using it directly)
  2. Use notarytool instead
@roryabraham
Copy link
Contributor Author

No update

@melvin-bot melvin-bot bot removed the Overdue label Jun 28, 2023
@roryabraham
Copy link
Contributor Author

I've looked through briefly and I think this is only used in Fastlane (for signing the iOS app)? It shouldn't be used for electron:

tool: 'notarytool',

@melvin-bot melvin-bot bot added the Overdue label Jul 7, 2023
@roryabraham
Copy link
Contributor Author

No update. I spent a bit of time and am still not confident where or how we are using altool.

@melvin-bot melvin-bot bot removed the Overdue label Jul 7, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 17, 2023
@roryabraham
Copy link
Contributor Author

No update

@melvin-bot melvin-bot bot removed the Overdue label Jul 18, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 26, 2023
@roryabraham
Copy link
Contributor Author

No update

@melvin-bot melvin-bot bot removed the Overdue label Jul 26, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 4, 2023
@roryabraham
Copy link
Contributor Author

No update

@melvin-bot melvin-bot bot removed the Overdue label Aug 8, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2023
@roryabraham
Copy link
Contributor Author

No update, no update planned soon. I can't find where this is used so I'm going to close this until it actually affects us. AFAIK there's no problem here.

@melvin-bot melvin-bot bot removed the Overdue label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant