Web - Automatically opens FAB menu on reload of room invite page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create a room
2. Copy the url (from share code)
3. Go to incognito browser
4. Paste the link
5. Reload and observe 2-3 times

Expected Result:

It should not open FAB menu

Actual Result:

Opens FAB menu on reload

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.30.0

Reproducible in staging?: y

Reproducible in production?: y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

bandicam.2023-06-14.20-14-08-310.mp4

Expensify/Expensify Issue URL:

Issue reported by: @chiragxarora

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686753816169919

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[namhihi237]

Proposal

Please re-state the problem that we are trying to solve in this issue.

It should not open FAB menu when open link room public

What is the root cause of that problem?

The problem here is that when opening the link room, it will run the function Message.show() with the function showCreateMenu as the number.

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js

Lines 86 to 94 in 7c04c2f

	componentDidMount() {
	const navigationState = this.props.navigation.getState();
	const routes = lodashGet(navigationState, 'routes', []);
	const currentRoute = routes[navigationState.index];
	if (currentRoute && ![NAVIGATORS.CENTRAL_PANE_NAVIGATOR, SCREENS.HOME].includes(currentRoute.name)) {
	return;
	}
	Welcome.show({routes, showCreateMenu: this.showCreateMenu});
	}

and then the function showCreateMenu will be run here, I think this logic is for new users just first join. I tried with new user login and it will run here.

App/src/libs/actions/Welcome.js

Lines 137 to 141 in 7c04c2f

	// If user is not already an admin of a free policy and we are not navigating them to their workspace or creating a new workspace via workspace/new then
	// we will show the create menu.
	if (!Policy.isAdminOfFreePolicy(allPolicies) && !isDisplayingWorkspaceRoute) {
	showCreateMenu();
	}

What changes do you think we should make in order to solve the problem?

App/src/libs/actions/Welcome.js

Line 115 in 7c04c2f

const topRoute = _.last(routes);

I think we need to check if the route has state.

if (!Policy.isAdminOfFreePolicy(allPolicies) && !isDisplayingWorkspaceRoute && !topRoute.state) {
  showCreateMenu();
}

Result:

Screen.Recording.2023-06-22.at.01.10.36.mov

What alternative solutions did you explore? (Optional)

We can replace it with the condition that the user is logged in or not, if logged in we mean the new user logged in for the first time and we will show it.

[alitoshmatov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Automatically opens FAB menu on reload of room invite page

What is the root cause of that problem?

We are opening FAB for anonymous users too.

What changes do you think we should make in order to solve the problem?

We should not trigger Welcome.show if user is is anonymous

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js

Line 93 in 98bb603

Welcome.show({routes, showCreateMenu: this.showCreateMenu});

We can add condition to check if user is logged in or not, by doing this, state.isAnonymousUser already exists in FAB component:

if (this.state.isAnonymousUser) {
            return;
        }

What alternative solutions did you explore? (Optional)

[twisterdotcom]

Discussed in Slack. This is expected: https://expensify.slack.com/archives/C049HHMV9SM/p1687391743204229?thread_ts=1686753816.169919&cid=C049HHMV9SM