-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web - Automatically opens FAB menu on reload of room invite page #21225
Comments
Triggered auto assignment to @twisterdotcom ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.It should not open FAB menu when open link room public What is the root cause of that problem?The problem here is that when opening the link room, it will run the function Message.show() with the function App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js Lines 86 to 94 in 7c04c2f
and then the function showCreateMenu will be run here, I think this logic is for new users just first join. I tried with new user login and it will run here. App/src/libs/actions/Welcome.js Lines 137 to 141 in 7c04c2f
What changes do you think we should make in order to solve the problem?App/src/libs/actions/Welcome.js Line 115 in 7c04c2f
I think we need to check if the route has state.
Result: Screen.Recording.2023-06-22.at.01.10.36.movWhat alternative solutions did you explore? (Optional)We can replace it with the condition that the user is logged in or not, if logged in we mean the new user logged in for the first time and we will show it. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Web - Automatically opens FAB menu on reload of room invite page What is the root cause of that problem?We are opening FAB for anonymous users too. What changes do you think we should make in order to solve the problem?We should not trigger
We can add condition to check if user is logged in or not, by doing this, state.isAnonymousUser already exists in FAB component:
if (this.state.isAnonymousUser) {
return;
} What alternative solutions did you explore? (Optional) |
Discussed in Slack. This is expected: https://expensify.slack.com/archives/C049HHMV9SM/p1687391743204229?thread_ts=1686753816.169919&cid=C049HHMV9SM |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
It should not open FAB menu
Actual Result:
Opens FAB menu on reload
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.30.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
bandicam.2023-06-14.20-14-08-310.mp4
Expensify/Expensify Issue URL:
Issue reported by: @chiragxarora
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686753816169919
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: