Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-06-24 #21477

Closed
45 tasks done
OSBotify opened this issue Jun 24, 2023 · 5 comments
Closed
45 tasks done

Deploy Checklist: New Expensify 2023-06-24 #21477

OSBotify opened this issue Jun 24, 2023 · 5 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jun 24, 2023

Release Version: 1.3.32-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@luacmartins luacmartins added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jun 24, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.32-5 🚀

@mvtglobally
Copy link

Regression is completed

PR #21286 is failing with old ki #19915. Checking off
PR #21136 is PRoD QA. Ok to check it off?
PR #21081 we are blocked on iOS as links don't open and there is continuous loading on Desktop. Also issue on mWeb not repro in PROD. Can you double check this PR? I think it was already deployed to PROD, so not sure if issue is related

@thienlnam
Copy link
Contributor

PR #21136 is PRoD QA. Ok to check it off?

Yup, also has been tested so I've checked it off

PR #21081 we are blocked on iOS as links don't open and there is continuous loading on Desktop. Also issue on mWeb not repro in PROD. Can you double check this PR? I think it was already deployed to PROD, so not sure if issue is related

Taking a look at this now

@thienlnam
Copy link
Contributor

thienlnam commented Jun 26, 2023

I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.

Screenshot 2023-06-26 at 1 19 38 PM

SIGTRAP not a fresh crash https://console.firebase.google.com/u/0/project/expensify-chat/crashlytics/app/android:com.expensify.chat/issues?state=open&time=last-seven-days&tag=all&sort=eventCount&issuesQuery=SIGTRAP

com.expensify.chat. MainApplication.onCreate is a fresh crash

AirshipHeadlessEventServiceSCompanion.startService is a fresh crash

NetworkMonitor.registerNetworkCallback is a fresh crash

com.google.android.a.a.a is a fresh crash

Going to mark this off, in all these fresh issues there's only a single crash and it was when the app was in the background state

@thienlnam
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants