-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-07-12] [$1000] 2FA - When the "copy code" button is clicked, the download button moves. #21566
Comments
Triggered auto assignment to @kevinksullivan ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.When the "copy code" button is clicked, the "Download" and "copy code" buttons should not move. Instead, they should remain fixed and only the internal data should change. What is the root cause of that problem?The problem here is that when clicking the copy button the code its content change resulting in the width button changing:
Lines 2216 to 2218 in f867c17
With the button on page VerifyPage the same as above
What changes do you think we should make in order to solve the problem?We can update minWidth of the button equal to the width when the text is
With button copy in VerifyPage we can add style:
And add style for the button:
Result: Screen.Recording.2023-06-26.at.21.30.05.movScreen.Recording.2023-06-27.at.00.29.15.movWhat alternative solutions did you explore? (Optional)Or we can use fix width for button:
|
ProposalPlease re-state the problem that we are trying to solve in this issue.2FA copy codes page copy button width gets changed on click What is the root cause of that problem?It seems we don't have provided the correct fixed width to the button and the button Section also gets overlapped to the padding area. What changes do you think we should make in order to solve the problem?As from the slack discussion fixed-width needs to provide to these buttons and considering the spanish text it requires approx 140px width. Below changes seems to be required for this.
Lines 2168 to 2176 in 468dd6c
Update the padding in the order of
Result Screen.Recording.2023-06-26.at.11.32.52.PM.movFor |
Job added to Upwork: https://www.upwork.com/jobs/~014f0d2000a41973c1 |
Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt ( |
@namhihi237 Thanks for the proposal. You RCA is correct and the solution looks good to me. 🎀 👀 🎀 C+ reviewed |
Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@Pujan92 Thanks for the proposal. Your RCA is not necessary wrong but we don't have to pass a fixed width, we already pass a min-width and we can just adjust that. |
Thanks @s77rt , I thought as we want to take out the moving effect we should provide the fixed width. Do you think other point of overlapping the button section makes sense? |
@Pujan92 I think min-width is enough for this case, the fixed width could back fire if the content is too large, it's better to see the moving effect than the text being cut or being shown in two lines. Not that this case would ever happen just noting. I think it would be okay going either way. Yes the other point makes sense but it's unrelated to this issue. |
hi @namhihi237 please apply for the job in upwork when you get a chance |
Offer sent for C+ @s77rt |
Applied job, please assign an issue for me thanks. |
📣 @namhihi237 You have been assigned to this job by @kevinksullivan! |
Sent the offer back @namhihi237 |
Accepted, thanks @kevinksullivan |
Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:
On to the next one 🚀 |
@s77rt, @kevinksullivan, @namhihi237, @aldo-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Not overdue. PR is merged and deployed to staging |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.36-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-07-12. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
|
Will pay out after regression period. |
Hello team any update payment for this. |
Paid @s77rt and @namhihi237 . @usmantariq96 sent offer for reporting. Lmk when you accept |
@kevinksullivan This is not eligible for the 50% bonus. I have refunded the bonus. |
@kevinksullivan the same with me. I have refunded. |
@kevinksullivan Offer accepted. |
Thanks everyone. Paid @usmantariq96 |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
When the "copy code" button is clicked, the "Download" and "copy code" buttons should not move. Instead they should remain fixed and only the internal data should change.
Actual Result:
When the "copy code" button is clicked, the "Download" and "copy code" buttons move.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.30-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug.14.mp4
Recording.5156.mp4
Expensify/Expensify Issue URL:
Issue reported by: @usmantariq96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687421108931499
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: