[Awaiting C+ Payment] [HOLD for payment 2023-08-01] [$1000] Dev: Email address is not displayed on task preview when user assigns task to themselves in DM

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a tab where user A is signed-in
2. Open an existing chat with user B
3. Click on 'Actions' icon
4. Click on 'Assign task' link
5. Enter title & click on 'Next' button
6. Click on 'Assignee' & assign the task to yourself
7. Click on 'Confirm task' button
8. Switch to the tab where account B is signed in
9. Open the chat with user A

Expected Result:

Task report item should display user A's email address for both user A, and user B

Actual Result:

User A's email address is not displayed on task report item for user B

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: DEV
Reproducible in staging?: Dev only
Reproducible in production?: dev only
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.2023-07-06.22-09-40.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688671191419889

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cae9815a84594b7f
• Upwork Job ID: 1678459591028834304
• Last Price Increase: 2023-07-17

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[trjExpensify]

I can't help repro this on dev, sorry. @thienlnam might be aware of any recent task related PRs that might have caused this.

[thienlnam]

Definitely not a deploy blocker if it's only on dev

[trjExpensify]

Are you able to repro though @thienlnam? Would be good to keep it moving if so!

[thienlnam]

Yup, looks like I can still reproduce

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cae9815a84594b7f

[melvin-bot]

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

The BZ member will need to manually hire natnael for the Reporter role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

[ShogunFire]

@mananjadhav PR ready for review

[melvin-bot]

🎯 ⚡️ Woah @mananjadhav / @ShogunFire, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @ShogunFire got assigned: 2023-07-17 18:03:47 Z
• when the PR got merged: 2023-07-19 21:00:12 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.44-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: when someone assign a task to himself and share it, his email hi… #23041

If no regressions arise, payment will be issued on 2023-08-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mananjadhav does not require payment (Eligable for Manual Requests)
• @ShogunFire requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mananjadhav]

I've added a comment to the offending PR.

I don't think any further action is needed on this one. I also don't think we need a regression test for this one.

@trjExpensify This would be ready for payout on 08/01, and eligible for timeline bonus.

[trjExpensify]

Yup, agreed this one is covered under the task report regression tests now added!

Confirming payments as follows:

$1,500 - @ShogunFire for the fix & #urgency bonus (offer sent)
$1,500 - @mananjadhav for the C+ review & #urgency bonus (Manan to request)
$250 - @Natnael-Guchima for the bug report.

Sent on this job.

[Natnael-Guchima]

Accepted the offer. Thanks, Tom.

[ShogunFire]

Hello @trjExpensify , thanks I accepted the offer but it was 1000$ instead of 1500$

[trjExpensify]

Yeah, that will usually happen. I then modify upon ending the contract to incl. the bonus :)

Settled up with @ShogunFire and @Natnael-Guchima! Over to you Manan. I'll close this issue once actioned.

[mananjadhav]

@trjExpensify I've raised a request on NewDot. I'll track the request there. You can close this one out.

[trjExpensify]

I believe we leave them open until confirmation on our side is provided on the GH, then we close. :) CC: @JmillsExpensify

[JmillsExpensify]

Reviewed details for @mananjadhav. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.

[trjExpensify]

Perfect, thanks. Closing!