Move Pin Action Into Context Menu and Remove Pin Button

[grgia]

Part of #20486 (comment)

Yeah, the intention was to move the pin action into the overflow menu. I like keeping things consistent and training the user that on basically every type of view (chat, task, expense, report, etc) you have an overflow menu that has additional options. So even if the pin is the only option available in some cases, I do like keeping things consistent by using the overflow menu

Relevant:
#22332 (comment)

Yeah, I left a similar comment over in the other issue but I think we should stay consistent with the
overflow menu on all of the various report type views (chat, thread, task, report, expense, etc). And then in the very least, it always has a pin option but it also might have:

call
delete
etc

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01229c410d2206c52f
• Upwork Job ID: 1678734041404153856
• Last Price Increase: 2023-07-11

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01229c410d2206c52f

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (Internal)

[grgia]

Relevant Convo: https://expensify.slack.com/archives/C02HWMSMZEC/p1687294634568589?thread_ts=1686946331.451439&cid=C02HWMSMZEC

[grgia]

I looked into this, and it's going to require some refactoring. I think we should handle this similarly to the report action context menus where we display different options depending on the reportAction (except here, we would display different options depending on the report)

[grgia]

@JmillsExpensify could you please help me locate the desired pin button / three dots menu item behavior for all report types?

[JmillsExpensify]

Apologies, just seeing this one.

[JmillsExpensify]

This is a bit tricky, since some of these haven't been mocked up. I'll go ahead and assign myself and come back to this.

[grgia]

Should we hold this? @JmillsExpensify

[JmillsExpensify]

@shawnborton @dannymcclain Can one of you take this on by chance? I haven't been able to get to it.

[shawnborton]

Sure, let's spin the wheel!

[melvin-bot]

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

[shawnborton]

Maybe we could combine the call options into the same menu with pin?

cc @trjExpensify as well

[trjExpensify]

Yeah, I think that works instead of an additional level. Once we have in-app calling & screenshare built, I think we remove the Zoom and Google Meet options completely.

[JmillsExpensify]

Nice, I agree on this path, including deprecating Meet and Zoom once we support in-app calling.

[grgia]

@JmillsExpensify can I get a priority gut check for this?

[trjExpensify]

With the design hashed out, can we make it external?

[grgia]

@trjExpensify good shout, I don't see why not.

Can we confirm that the above screenshots are the final design with options:

• Pin
• Zoom
• Google Meet

And then we need to know:

• Which types of reports show these options
• What happens on click for all of the options

[shawnborton]

Actually I think we have some overlap here, pretty sure @srikarparsi submitted a PR for this already in relation to some thread/subscribe/unsubscribe changes?

[srikarparsi]

Oh yup right here: #27748

[trjExpensify]

Dope, let's close this then or link that PR to this issue perhaps?

[shawnborton]

Going to close this since this one is live already. Nice work @srikarparsi