Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-09-07] Display recent destinations on waypoint editor #22714

Closed
neil-marcellini opened this issue Jul 11, 2023 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Monthly KSv2 Reviewing Has a PR in review

Comments

@neil-marcellini
Copy link
Contributor

Please follow the plan in the design doc: Display recent destinations on waypoint editor.

@melvin-bot
Copy link

melvin-bot bot commented Jul 17, 2023

Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Jul 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 19, 2023

6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@neil-marcellini neil-marcellini added Weekly KSv2 and removed Daily KSv2 labels Jul 20, 2023
@melvin-bot melvin-bot bot removed the Overdue label Jul 20, 2023
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Aug 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 21, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@neil-marcellini
Copy link
Contributor Author

This is going to come off hold pretty soon.

@neil-marcellini neil-marcellini added Weekly KSv2 and removed Monthly KSv2 labels Aug 21, 2023
@tgolen tgolen added Daily KSv2 and removed Weekly KSv2 labels Aug 22, 2023
@tgolen tgolen self-assigned this Aug 22, 2023
@tgolen
Copy link
Contributor

tgolen commented Aug 22, 2023

I'll start work on this tomorrow.

@tgolen tgolen changed the title [HOLD 22711] Display recent destinations on waypoint editor Display recent destinations on waypoint editor Aug 23, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 24, 2023
@tgolen
Copy link
Contributor

tgolen commented Aug 24, 2023

I have only preliminarily began looking into this and I've been focusing on other CRITICAL tasks. Once those are all done (hopefully today), I will be able to put all my focus into this. ETA is to have it done and ready for review by the end of tomorrow (Friday).

@melvin-bot melvin-bot bot removed the Overdue label Aug 24, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Weekly KSv2 labels Aug 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 30, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Aug 31, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Aug 31, 2023
@melvin-bot melvin-bot bot changed the title Display recent destinations on waypoint editor [HOLD for payment 2023-09-07] Display recent destinations on waypoint editor Aug 31, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 31, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 31, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 31, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.59-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-09-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot
Copy link

melvin-bot bot commented Sep 1, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Sep 2, 2023
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Sep 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 25, 2023

This issue has not been updated in over 15 days. @tgolen eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@tgolen
Copy link
Contributor

tgolen commented Oct 2, 2023

This is all done and nothing else needs to be done

@tgolen tgolen closed this as completed Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

2 participants