-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-09-07] [$1000] Web - Multi word zones do not work while searching for Timezones #23543
Comments
Triggered auto assignment to @alexpensify ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.We want to be able to search all multi-word time zones. What is the root cause of that problem?When we filter the search results here, we directly compare the lowercase timezone values to lowercase search value, without checking for Some timezones also have
What changes do you think we should make in order to solve the problem?We should use some regex when filtering out results and replace Optional:
What alternative solutions did you explore? (Optional)N/A |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Multi word zones do not work while searching for Timezones What is the root cause of that problem?When searching for a timezone, we do not replace existing "_" and "-" with " ", so 2 or more words zones will not appear when searched for: App/src/pages/settings/Profile/TimezoneSelectPage.js Lines 105 to 110 in 82669ae
What changes do you think we should make in order to solve the problem?We should replace "_" & "-" with " " when filtering timezones: timezoneOptions: _.filter(this.allTimezones, (tz) => tz.text.replace('_', ' ').replace('-', ' ').toLowerCase().includes(searchText.trim().toLowerCase())),
``` (edited) |
ProposalPlease re-state the problem that we are trying to solve in this issue.Multi word zones do not work while searching for Timezones What is the root cause of that problem?The timezone names can contain special characters instead of spaces, including _ - and /. What changes do you think we should make in order to solve the problem?When searching, we should replace _ - and / with a space in both the search query and the timezone name, before running the search comparison in This improves on the proposals above in the following manner:
What alternative solutions did you explore? (Optional)N/A |
I've run out of time and will test soon. |
I'm OOO today. I'll try to review it over the weekend. |
Not overdue - still on my testing lists |
@alexpensify its reproducible with 2 or more works, can you please try with these
etc |
@alexpensify I think that the Slack thread also has some context which may help for better understanding of the bug. |
Ok, I see the issue now. I misunderstood this:
You have to input two-word cities to generate this error. |
Job added to Upwork: https://www.upwork.com/jobs/~0183d12241aacbaee9 |
Current assignee @alexpensify is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh ( |
@fedirjh when you get a chance, can you please review the proposals? Thank you! |
ProposalPlease re-state the problem that we are trying to solve in this issue.Multi word zones do not work while searching for Timezones What is the root cause of that problem?Multi-word timezones are entered with the '_' character instead of a space. It cannot be searched with spaces, as it simply compares only those that contain the same string. What changes do you think we should make in order to solve the problem?Currently, timezone is entered with '_', but we don't know what other characters will be entered in the future. We can create a similar "Search Everywhere" feature using the following code. filterShownTimezones(searchText) {
this.setState({
timezoneInputText: searchText,
timezoneOptions: _.filter(this.allTimezones, (tz) => new RegExp(searchText.trim().replaceAll(/\s+/g, '.*'), 'i').test(tz.text)),
});
} What alternative solutions did you explore? (Optional)N/A |
📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @DanutGavrus 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
📣 @DanutGavrus 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app! |
Awesome, we will continue to follow along with the process. |
Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:
On to the next one 🚀 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.59-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-09-07. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@fedirjh to prepare for the payment day, can you please complete the checklist? Thanks! |
BugZero Checklist:
Regression Test Proposal
|
@bondydaa to prepare for payment day, can you review and approve the regression test? Thanks! |
Here is the payment summary:
Upwork Job: https://www.upwork.com/jobs/~0183d12241aacbaee9 *If applicable, the bonuses will be applied on the final payment Extra Notes regarding payment: There is no bonus here and I'm going to use the C+ approval date since there was a delay because of the US Bank Holiday. In saying that, it was 5 business days-- no penalties. |
Everyone has been paid in Upwork! |
@bondydaa - let me know if you agree with the regression test and I can create that GH. |
👍 to the suggested steps. Though I'm wondering if we could somehow create an automated unit test for this component https://github.com/Expensify/App/tree/main/tests/unit? my brain is dead today so not sure what that all would entail but if we can I'd prefer automate tests over manual ones. |
Thanks, I'm OOO until Thursday and will create the regression test then. |
The regression test request has been created, so I'm going to close now. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Multi word Timezones should appear in the results.
Actual Result:
Multi word Timezones do not appear in the results.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
multi_word_timezones.mp4
Expensify/Expensify Issue URL:
Issue reported by: @DanutGavrus
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690204863367949
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: