[HOLD for payment 2023-08-10] [HOLD for payment 2023-08-08] [$1000] IOU - Double "request money" tab if request money

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #22649

Action Performed:

1. Open https://staging.new.expensify.com/
2. Click on "+" in any chat / click on FAB menu
3. Click on "Request money"
4. Insert amount
5. Click "Next"

Expected Result:

At step 5 user lands in IOU summary (with destination, amount and description)

Actual Result:

At step 5 user lands in the same "insert amount" tab, it is duplicated.
Also if user switches to a different chat and requests money - amount from previous IOU would be dispalyed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.48.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6148594_Recording__840.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d986e83acbb6b2e5
• Upwork Job ID: 1686336524126748672
• Last Price Increase: 2023-08-01

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[hayata-suenaga]

the product can be still used. the user just have to click twice. this is not a deploy blocker

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hayata-suenaga]

@mountiny do you think this is part of regression from the navigation refactoring?

[hungvu193]

Hey if it's considered as a bug, please update me as reporter. I reported it few days ago, but it wasn't logged:
https://expensify.slack.com/archives/C049HHMV9SM/p1690591424340319

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mountiny]

@hayata-suenaga I think this one should still be a blocker, its should not be related to any navigation changes in general, those were deployed a while ago

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d986e83acbb6b2e5

[melvin-bot]

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.49-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] [Revert] Perf/onyx upgrade use cache directly #24003

If no regressions arise, payment will be issued on 2023-08-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @aimane-chnaif requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[aimane-chnaif]

Regarding BZ Checklist:

This was regression from performance upgrade in Onyx. The author (@hannojg) is already aware of it.
And this was caught by Applause team, so no need regression test.

[melvin-bot]

@mallenexpensify, @aimane-chnaif, @hayata-suenaga Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@mallenexpensify, @aimane-chnaif, @hayata-suenaga Still overdue 6 days?! Let's take care of this!

[hayata-suenaga]

@mallenexpensify I'd appreciate if you could take care of payment when you have time 🙇

[mallenexpensify]

Sorry for the (lonnnnng) delay. It appears @aimane-chnaif is the only one due compensation, for C+ review of the PR. If so, @aimane-chnaif , can you please accept the job and reply here once you have? https://www.upwork.com/jobs/~01d986e83acbb6b2e5

[melvin-bot]

@mallenexpensify, @aimane-chnaif, @hayata-suenaga Eep! 4 days overdue now. Issues have feelings too...

[mallenexpensify]

Contributor+: @aimane-chnaif paid $1000 via Upwork.

[hungvu193]

Hey if it's considered as a bug, please update me as reporter. I reported it few days ago, but it wasn't logged: https://expensify.slack.com/archives/C049HHMV9SM/p1690591424340319

@mallenexpensify I think I'm eligible for reporting bonus because I reported this issue firstly on slack.