[HOLD https://github.com/Expensify/App/pull/24137] Assign task - We are able to open archived chat's description via deeplink

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open website
2. Click on plus icon > Assign task > Type something to title and click on btn > Choose assigners > Click on confirm task btn > After opening the chat for it , Click on Description and copy the deeplink
3. Cancel the task and paste the URL and open it

Expected Result:

We should not be able to open archived chat's description via deeplink

Actual Result:

We are able to open archived chat's description via deeplink

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.54.11

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

screen-capture.94.webm

Recording.5877.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: @MahmudjonToraqulov

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691402788238729

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ee1805503af10326
• Upwork Job ID: 1692557939712176128
• Last Price Increase: 2023-08-18

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Assign task - We are able to open archived chat's description via deeplink

What is the root cause of that problem?

We are not stopping user from accessing title,description pages when task is cancelled.

What changes do you think we should make in order to solve the problem?

We can use FullPageNotFoundView and we can add a check ReportUtils.isCanceledTaskReport. This solution can be applied to the description page, title page, or any other page where this bug occurs.

What alternative solutions did you explore? (Optional)

[alphaboss1104]

This is BE issue. When we cancel the task BE returns the correct report's statusNum(2). But if we copy the deeplink and open it, the BE returns wrong report's statusNum(0).

[CortneyOfstad]

Thanks @alphaboss1104! Getting eyes on this now 👍

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ee1805503af10326

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Santhosh-Sellavel (Internal)

[melvin-bot]

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[CortneyOfstad]

@aldo-expensify Does this seem like a BE issue? Just wanted confirmation — TIA!

[aldo-expensify]

Maybe, I'll try to look into it later during the day

[aldo-expensify]

cc @thienlnam

I think this PR made the backend stop changing the state/status of the report. Maybe the frontend needs to be updated accordingly. Waiting on Jack to confirm.

[aldo-expensify]

Ahh, @thienlnam seems to be working on this at the moment here: #24137
I'm guessing we should HOLD until that is done or close this

[CortneyOfstad]

On hold — so not overdue 👍

Going to set this as weekly

[CortneyOfstad]

Still on-hold 👍

[CortneyOfstad]

@aldo-expensify Just checking to see if thee is an update — TIA!

[aldo-expensify]

#24137 is still a draft
@thienlnam that is still on progress right? or did we decide to go some other direction?

[thienlnam]

Still in progress - haven't had time to prioritize

[Santhosh-Sellavel]

on Hold

[thienlnam]

Merged, we can try to see if this is still a problem on main

[aldo-expensify]

If we try to access the description using the link, we see now the not found message "Hmm... It's not here"

I guess this is fixed now?

[thienlnam]

Yup that looks correct

[aldo-expensify]

Thanks @thienlnam , closing then