Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [HOLD for payment 2023-11-21] [HOLD] [TS migration] Migrate 'getContextMenuItemStyles' style to TypeScript #24726

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 25 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/styles/getContextMenuItemStyles/index.native.js 1
src/styles/getContextMenuItemStyles/index.js 2
Issue OwnerCurrent Issue Owner: @BartoszGrajdek
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a7e1ebfee84aafa7
  • Upwork Job ID: 1726957355170693120
  • Last Price Increase: 2023-11-21
@BartoszGrajdek
Copy link
Contributor

Hey! I’m Bartosz from Software Mansion, an expert agency, and I’d like to work on this issue!

@hayata-suenaga
Copy link
Contributor

should there be hold on this issue?

@BartoszGrajdek
Copy link
Contributor

@hayata-suenaga yes please :)

@melvin-bot melvin-bot bot removed the Overdue label Aug 29, 2023
@hayata-suenaga hayata-suenaga changed the title [TS migration] Migrate 'getContextMenuItemStyles' style to TypeScript [HOLD] [TS migration] Migrate 'getContextMenuItemStyles' style to TypeScript Aug 30, 2023
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Sep 21, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 21, 2023

This issue has not been updated in over 15 days. @BartoszGrajdek eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 21, 2023
@hayata-suenaga
Copy link
Contributor

this is on hold

Copy link
Author

melvin-bot bot commented Nov 8, 2023

Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 14, 2023
@melvin-bot melvin-bot bot changed the title [HOLD] [TS migration] Migrate 'getContextMenuItemStyles' style to TypeScript [HOLD for payment 2023-11-21] [HOLD] [TS migration] Migrate 'getContextMenuItemStyles' style to TypeScript Nov 14, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 14, 2023
Copy link
Author

melvin-bot bot commented Nov 14, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Nov 14, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.98-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@alitoshmatov
Copy link
Contributor

Can you assign me as C+ reviewer to process payment

@hayata-suenaga hayata-suenaga added the Bug Something is broken. Auto assigns a BugZero manager. label Nov 16, 2023
Copy link
Author

melvin-bot bot commented Nov 16, 2023

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 16, 2023
Copy link
Author

melvin-bot bot commented Nov 16, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@hayata-suenaga
Copy link
Contributor

@zanyrenney please handle the payment of $250 to @alitoshmatov for the C+ review of the PR 🙇

Copy link
Author

melvin-bot bot commented Nov 20, 2023

@BartoszGrajdek, @zanyrenney, @alitoshmatov, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Nov 20, 2023
@zanyrenney
Copy link
Contributor

payment due tomorrow, though, right @hayata-suenaga ?

@hayata-suenaga
Copy link
Contributor

ah yea that's right. it's just a memo sorry for the confusion 🙇

@zanyrenney
Copy link
Contributor

no problem! just wanted to make sure I wasn't incorrect in following the date. TY!

@melvin-bot melvin-bot bot added Overdue Daily KSv2 and removed Daily KSv2 Overdue labels Nov 20, 2023
@zanyrenney zanyrenney added External Added to denote the issue can be worked on by a contributor and removed Bug Something is broken. Auto assigns a BugZero manager. labels Nov 21, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-11-21] [HOLD] [TS migration] Migrate 'getContextMenuItemStyles' style to TypeScript [$500] [HOLD for payment 2023-11-21] [HOLD] [TS migration] Migrate 'getContextMenuItemStyles' style to TypeScript Nov 21, 2023
Copy link
Author

melvin-bot bot commented Nov 21, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01a7e1ebfee84aafa7

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 21, 2023
Copy link
Author

melvin-bot bot commented Nov 21, 2023

Current assignee @alitoshmatov is eligible for the External assigner, not assigning anyone new.

@zanyrenney zanyrenney changed the title [$500] [HOLD for payment 2023-11-21] [HOLD] [TS migration] Migrate 'getContextMenuItemStyles' style to TypeScript [$250] [HOLD for payment 2023-11-21] [HOLD] [TS migration] Migrate 'getContextMenuItemStyles' style to TypeScript Nov 21, 2023
Copy link
Author

melvin-bot bot commented Nov 21, 2023

Upwork job price has been updated to $250

@zanyrenney
Copy link
Contributor

@alitoshmatov invited you to the job, please accept.

@alitoshmatov
Copy link
Contributor

@zanyrenney I think something went wrong, I don't see any offer. Also I can't apply to the provided upwork job

@zanyrenney
Copy link
Contributor

Can you check again?I see you there with an unanswered invite: @alitoshmatov
2023-11-21_17-44-58

@alitoshmatov
Copy link
Contributor

@zanyrenney Now it worked

@zanyrenney
Copy link
Contributor

offer sent, please accept for payout.

@zanyrenney
Copy link
Contributor

zanyrenney commented Nov 23, 2023

Payment summary for @alitoshmatov $250 - complete
@BartoszGrajdek does not require payment (Contractor)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Task Typescript Migration
Projects
Development

No branches or pull requests

4 participants