Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate 'getPermittedDecimalSeparator' lib to TypeScript #24837

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 14 comments
Closed

[TS migration] Migrate 'getPermittedDecimalSeparator' lib to TypeScript #24837

melvin-bot bot opened this issue Aug 16, 2023 · 14 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/libs/getPermittedDecimalSeparator/index.js 3
src/libs/getPermittedDecimalSeparator/index.ios.js 0
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018af9e9492b9d142a
  • Upwork Job ID: 1735424298851090432
  • Last Price Increase: 2023-12-14
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@BartoszGrajdek
Copy link
Contributor

Hey! I’m Bartosz from Software Mansion, an expert agency, and I’d like to work on this issue!

@blazejkustra
Copy link
Contributor

@BartoszGrajdek Why is this on hold?

Copy link
Author

melvin-bot bot commented Nov 7, 2023

Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@shubham1206agra
Copy link
Contributor

Can you assign me here?

@shubham1206agra
Copy link
Contributor

This got merged 3 weeks ago. Please process payment here

@shubham1206agra
Copy link
Contributor

Bump @AndrewGable

@mallenexpensify mallenexpensify self-assigned this Dec 14, 2023
@mallenexpensify mallenexpensify added the Internal Requires API changes or must be handled by Expensify staff label Dec 14, 2023
Copy link
Author

melvin-bot bot commented Dec 14, 2023

Job added to Upwork: https://www.upwork.com/jobs/~018af9e9492b9d142a

@mallenexpensify mallenexpensify added the Bug Something is broken. Auto assigns a BugZero manager. label Dec 14, 2023
Copy link
Author

melvin-bot bot commented Dec 14, 2023

Current assignee @mallenexpensify is eligible for the Bug assigner, not assigning anyone new.

Copy link
Author

melvin-bot bot commented Dec 14, 2023

Current assignee @shubham1206agra is eligible for the Internal assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Daily KSv2 label Dec 14, 2023
Copy link
Author

melvin-bot bot commented Dec 14, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Dec 14, 2023
@mallenexpensify
Copy link
Contributor

@shubham1206agra , can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~018af9e9492b9d142a

@shubham1206agra
Copy link
Contributor

Done

@mallenexpensify
Copy link
Contributor

Contributor+: @shubham1206agra paid $250 via Upwork.

I don't think anyone else is due compensation here, plz comment if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Task Typescript Migration
Projects
Development

No branches or pull requests

5 participants