Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-07] [$250] [TS migration] Migrate 'ImageView' component to TypeScript #25113

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 28 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/ImageView/index.native.js 10
src/components/ImageView/index.js 11
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015b473321babdbefb
  • Upwork Job ID: 1744724126155382784
  • Last Price Increase: 2024-01-09
  • Automatic offers:
    • s77rt | Reviewer | 28090714
    • tienifr | Contributor | 28090715
Issue OwnerCurrent Issue Owner: @dylanexpensify
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@mountiny mountiny added External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. and removed Not a priority labels Jan 9, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'ImageView' component to TypeScript [$500] [TS migration] Migrate 'ImageView' component to TypeScript Jan 9, 2024
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Job added to Upwork: https://www.upwork.com/jobs/~015b473321babdbefb

Copy link
Author

melvin-bot bot commented Jan 9, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors and removed Overdue Monthly KSv2 labels Jan 9, 2024
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 9, 2024
@tienifr
Copy link
Contributor

tienifr commented Jan 9, 2024

I can work on this (if open for contributors)

@mountiny mountiny changed the title [$500] [TS migration] Migrate 'ImageView' component to TypeScript [$250] [TS migration] Migrate 'ImageView' component to TypeScript Jan 9, 2024
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Upwork job price has been updated to $250

@5war00p
Copy link
Contributor

5war00p commented Jan 9, 2024

I would love to contribute to this

@rayane-djouah
Copy link
Contributor

I would like to work on this

@ghost
Copy link

ghost commented Jan 9, 2024

Dibs

@shahinyan11
Copy link
Contributor

I would like to work on this

@dylanexpensify
Copy link
Contributor

We've hired for this.

@dylanexpensify
Copy link
Contributor

@tienifr @s77rt mind giving an update?

@s77rt
Copy link
Contributor

s77rt commented Jan 23, 2024

@dylanexpensify 99% ready for merge. There is failing test "Reassure Performance Tests" which I think we can get fixed once we merge main.

@dylanexpensify
Copy link
Contributor

Nice, we got merge!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 31, 2024
@melvin-bot melvin-bot bot changed the title [$250] [TS migration] Migrate 'ImageView' component to TypeScript [HOLD for payment 2024-02-07] [$250] [TS migration] Migrate 'ImageView' component to TypeScript Jan 31, 2024
Copy link
Author

melvin-bot bot commented Jan 31, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 31, 2024
Copy link
Author

melvin-bot bot commented Jan 31, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-07. 🎊

For reference, here are some details about the assignees on this issue:

Copy link
Author

melvin-bot bot commented Jan 31, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@s77rt] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@s77rt
Copy link
Contributor

s77rt commented Jan 31, 2024

No regression test is required here. Not a NewFeature

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 6, 2024
@dylanexpensify
Copy link
Contributor

payment today!

@melvin-bot melvin-bot bot added the Overdue label Feb 9, 2024
@dylanexpensify
Copy link
Contributor

Payment summary:

@melvin-bot melvin-bot bot removed the Overdue label Feb 12, 2024
@dylanexpensify
Copy link
Contributor

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Task Typescript Migration
Projects
Development

No branches or pull requests

10 participants