Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate 'ScreenWrapper' component to TypeScript #25128

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 16 comments
Closed

[TS migration] Migrate 'ScreenWrapper' component to TypeScript #25128

melvin-bot bot opened this issue Aug 16, 2023 · 16 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Not a priority Reviewing Has a PR in review Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/ScreenWrapper/propTypes.js 4
src/components/ScreenWrapper/index.js 22
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@blazejkustra
Copy link
Contributor

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

Copy link
Author

melvin-bot bot commented Jan 3, 2024

Triggered auto assignment to @srikarparsi, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@c3024
Copy link
Contributor

c3024 commented Jan 3, 2024

🎀 👀 🎀
C+ Reviewed

for internal engineer assignment for approving and merging PR.

Copy link
Author

melvin-bot bot commented Jan 3, 2024

Current assignee @srikarparsi is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Jan 29, 2024
Copy link
Author

melvin-bot bot commented Jan 29, 2024

This issue has not been updated in over 15 days. @srikarparsi eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@NicMendonca NicMendonca added the Bug Something is broken. Auto assigns a BugZero manager. label Jan 29, 2024
Copy link
Author

melvin-bot bot commented Jan 29, 2024

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Jan 29, 2024
@c3024
Copy link
Contributor

c3024 commented Jan 29, 2024

FYI I reviewed the PR #33870 for this TS migration.

@zanyrenney
Copy link
Contributor

@srikarparsi, I'm not clear who is due the payment - please can you review and let me know?

@srikarparsi
Copy link
Contributor

Hey! We just need to pay @c3024 $250 for reviewing this TypeScript migration PR

@zanyrenney
Copy link
Contributor

@zanyrenney
Copy link
Contributor

invited to the job!

@zanyrenney
Copy link
Contributor

@c3024
Copy link
Contributor

c3024 commented Feb 1, 2024

Thanks. Accepted. @zanyrenney

@zanyrenney
Copy link
Contributor

paid out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Not a priority Reviewing Has a PR in review Task Typescript Migration
Projects
Development

No branches or pull requests

5 participants