Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$250] [HOLD for payment 2024-01-11] [TS migration] Migrate 'TextInput' component to TypeScript #25146

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 18 comments
Closed

[$250] [HOLD for payment 2024-01-11] [TS migration] Migrate 'TextInput' component to TypeScript #25146

melvin-bot bot opened this issue Aug 16, 2023 · 18 comments
Assignees
@Beamanator @sakluger @fedirjh
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Not a priority Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023 •
edited
Loading

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/TextInput/styleConst.js 1
src/components/TextInput/index.native.js 4
src/components/TextInput/index.js 9
src/components/TextInput/baseTextInputPropTypes.js 1
src/components/TextInput/BaseTextInput.js 22
src/components/TextInput/TextInputLabel/index.native.js 5
src/components/TextInput/TextInputLabel/index.js 5
src/components/TextInput/TextInputLabel/TextInputLabelPropTypes.js 2
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01209e2c93999e03e1
  • Upwork Job ID: 1746946476979544064
  • Last Price Increase: 2024-01-15
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Sep 11, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@kubabutkiewicz
Copy link
Contributor

Hi, I'm Jakub from Callstack - expert contributor group - and I would like to take a look at this issue.

@melvin-bot melvin-bot bot added the Overdue label Nov 14, 2023
@kubabutkiewicz kubabutkiewicz mentioned this issue Nov 15, 2023
Merged
50 tasks
@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@fabioh8010
Copy link
Contributor

@kubabutkiewicz

Updated List

Files

Path Dependencies
src/components/TextInput/styleConst.js 1
src/components/TextInput/index.native.js 5
src/components/TextInput/index.js 9
src/components/TextInput/TextInputLabel/index.native.js 5
src/components/TextInput/TextInputLabel/index.js 5
src/components/TextInput/TextInputLabel/TextInputLabelPropTypes.js 2
src/components/TextInput/BaseTextInput/index.native.js 24
src/components/TextInput/BaseTextInput/index.js 24
src/components/TextInput/BaseTextInput/baseTextInputPropTypes.js 1

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Dec 15, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Dec 28, 2023

Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 4, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'TextInput' component to TypeScript [HOLD for payment 2024-01-11] [TS migration] Migrate 'TextInput' component to TypeScript Jan 4, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 4, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 4, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 4, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.21-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-11. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 11, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 11, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@fedirjh
Copy link
Contributor

fedirjh commented Jan 11, 2024

cc @Beamanator Could you please assign me this one as C+ . Thank you.

@Beamanator Beamanator added the Bug Something is broken. Auto assigns a BugZero manager. label Jan 12, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 12, 2024

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@Beamanator
Copy link
Contributor

@sakluger assigning you to help with payout please! 🙏

@melvin-bot melvin-bot bot added the Overdue label Jan 14, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 15, 2024

@Beamanator, @sakluger, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@sakluger sakluger added the External Added to denote the issue can be worked on by a contributor label Jan 15, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-01-11] [TS migration] Migrate 'TextInput' component to TypeScript [$500] [HOLD for payment 2024-01-11] [TS migration] Migrate 'TextInput' component to TypeScript Jan 15, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 15, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01209e2c93999e03e1

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 15, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 15, 2024

Current assignee @fedirjh is eligible for the External assigner, not assigning anyone new.

@sakluger sakluger changed the title [$500] [HOLD for payment 2024-01-11] [TS migration] Migrate 'TextInput' component to TypeScript [$250] [HOLD for payment 2024-01-11] [TS migration] Migrate 'TextInput' component to TypeScript Jan 15, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 15, 2024

Upwork job price has been updated to $250

@sakluger
Copy link
Contributor

@fedirjh sent you an offer via via Upwork. Please let me know once you've accepted. 🙇

@melvin-bot melvin-bot bot removed the Overdue label Jan 15, 2024
@fedirjh
Copy link
Contributor

fedirjh commented Jan 15, 2024

@sakluger Thank you. Accepted.

@sakluger
Copy link
Contributor

Thank you Fedi, payment complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Beamanator Beamanator

@sakluger sakluger

@fedirjh fedirjh

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Not a priority Task Typescript Migration
Projects
Typescript migration
Status: Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Beamanator @sakluger @fabioh8010 @kubabutkiewicz @fedirjh