Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate 'GitUtils.js' .github file to TypeScript #25375

Closed
melvin-bot bot opened this issue Aug 17, 2023 · 5 comments
Closed

[TS migration] Migrate 'GitUtils.js' .github file to TypeScript #25375

melvin-bot bot opened this issue Aug 17, 2023 · 5 comments
Assignees
Labels
NewFeature Something to build that is a new item. Not a priority Reviewing Has a PR in review Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
.github/libs/GitUtils.js 5
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot reopened this Nov 23, 2023
Copy link
Author

melvin-bot bot commented Feb 5, 2024

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Copy link
Author

melvin-bot bot commented Feb 19, 2024

Triggered auto assignment to @flodnv, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@mananjadhav
Copy link
Collaborator

Cross posting the comment.

@mountiny @mallenexpensify @flodnv Based on this comment I am going to approve the PR. But the PR contains 54 files updates with minor changes, does it need a C+ review?

@melvin-bot melvin-bot bot added the NewFeature Something to build that is a new item. label Feb 19, 2024
Copy link
Author

melvin-bot bot commented Feb 19, 2024

@flodnv flodnv closed this as completed Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Not a priority Reviewing Has a PR in review Task Typescript Migration Weekly KSv2
Projects
Development

No branches or pull requests

3 participants