[$500] [Awaiting payment]The formatting of the time is zero-prefixed

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app
2. Navigate to any chat
3. Check timezone display

Expected Result:

The formatting of the time should not be zero-prefixed

Actual Result:

The formatting of the time is zero-prefixed

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.56-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692671896444999

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b09a40192967b0dd
• Upwork Job ID: 1699744670108016640
• Last Price Increase: 2023-09-07

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The formatting of the time is zero-prefixed

What is the root cause of that problem?

We updated the format for local time here which caused this issue:

App/src/CONST.js

Line 131 in 120bcbf

LOCAL_TIME_FORMAT: 'hh:mm a',

What changes do you think we should make in order to solve the problem?

We should update this:

App/src/CONST.js

Line 131 in 120bcbf

LOCAL_TIME_FORMAT: 'hh:mm a',

to:

LOCAL_TIME_FORMAT: 'h:mm a',

What alternative solutions did you explore? (Optional)

N/A

[himanshuragi456]

looks like expected behavior.

[situchan]

As #24446 is within regression period, they will be handling this

[MonilBhavsar]

@waterim since this was a regression, do you mind if I assign you to this issue and you can make a quick fix?

[waterim]

@MonilBhavsar yes, sure, Im taking this one, thank you for the mention

[MonilBhavsar]

Thank you! Happy to review the PR.

[waterim]

@MonilBhavsar do I need to write a proposal here? Because this change is just removing one char from the time CONST

[MonilBhavsar]

That's fine 👍 No need of proposal

[mountiny]

Thanks! happy to review as well since I have helped with the original PR

[MonilBhavsar]

The PR was deployed to production. We can issue the payment to C+ and close this issue

[melvin-bot]

@allroundexperts @MonilBhavsar @waterim @laurenreidexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b09a40192967b0dd

[melvin-bot]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @allroundexperts is eligible for the External assigner, not assigning anyone new.

[laurenreidexpensify]

Woops forgot @allroundexperts was on the C+ payment pilot

[laurenreidexpensify]

@MonilBhavsar just to be clear - is there no C payment here, it's only $1000 for @allroundexperts is that corretc?

[MonilBhavsar]

Correct, contributor - @waterim are from expert agency. Also just to note, this was a regression from #24446

[melvin-bot]

@allroundexperts, @MonilBhavsar, @waterim, @laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@allroundexperts, @MonilBhavsar, @waterim, @laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MonilBhavsar]

@laurenreidexpensify is partially ooo today

[melvin-bot]

@allroundexperts @MonilBhavsar @waterim @laurenreidexpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[laurenreidexpensify]

Payment summary:

• bug report internal $0
• C fix - expert contributor $0
• C+ review - @allroundexperts pls request $1000 in newdot

When @allroundexperts confirms payment has been requested we can close

[allroundexperts]

Hi @laurenreidexpensify!
This was a regression. As such, there isn't any payment due here.