-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hold for payment 2023-08-30] [$1000] Google icon on sign in page shows overflow horizontal scrolling bars #25797
Comments
Triggered auto assignment to @greg-schroeder ( |
Bug0 Triage Checklist (Main S/O)
|
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @luacmartins ( |
I have a quick fix: Line 3648 in 8d5ae3a
replacing overflowY: 'hidden' -> overflow: 'hidden' fixes this bug
|
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
@0xmiroslav has a solution here: https://expensify.slack.com/archives/C049HHMV9SM/p1692821650897609?thread_ts=1692820693.322909&cid=C049HHMV9SM Sounds about right to me. |
This comment was marked as off-topic.
This comment was marked as off-topic.
@0xmiroslav mind completing the BZ checklist when you have a sec so we can prep to issue payment? TY! |
Still pending BZ checklist completion |
As this is super minor UI bug and follow-up of new google signin feature, no need regression test. |
BZ checklist is complete! |
Only payment we need to make here is $1,500 to @0xmiroslav. $1,000 for their PR, and then $500 speed bonus since this PR was merged in less than one day! |
My payment method is still in discussion. Please hold my payment yet and update to weekly. Thanks |
Sounds good! LMK once you're ready to proceed. |
@0xmiroslav is payment here still held? |
yes |
Got it, ty! |
@0xmiroslav is this still blocked? |
yes still |
Maybe we can combine all held payment in a single tracking issue and close this one? |
@0xmiroslav Do you expect the issue to be resolved soon? If it's going to be this week, IMO it feels simpler to just wait and pay this. But if not, agree it may make sense to look into consolidating. |
I will update you asap. I am also still waiting for update from my local accountant. |
@0xmiroslav any update here? |
Not yet but soon. Let's close this for now so you don't get notified. I am tracking so will ping here when ready. |
Got it, sounds good. TY! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Describe what you think should've happened
Actual Result:
Describe what actually happened
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number:
Reproducible in staging?: Yes
Reproducible in production?: No (IT IS A NEW FEATURE)
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @marcaaron
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: