Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU Distance - Part of the address in the address field is removed when the address is long #26325

Closed
1 of 6 tasks
lanitochka17 opened this issue Aug 30, 2023 · 4 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 30, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #25974

Action Performed:

  1. Launch New Expensify app
  2. Go to + > Request money > Distance > Start
  3. Enter San Francisco and select the one with long address like San Francisco Pier 33 - Alcatraz Island, San Francisco, CA, USA
  4. Click on Start again

Expected Result:

The address selected is complete in the address field

Actual Result:

The address selected is not complete in the address field. Part of the address is removed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.59-4

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6183071_Screen_Recording_20230831_010807_New_Expensify__1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 30, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 30, 2023

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 30, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@hungvu193
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU Distance - Part of the address in the address field is removed when the address is long

What is the root cause of that problem?

We're limiting the address text input length here, so when the address is longer than CONST.FORM_CHARACTER_LIMIT which is 50 characters, we couldn't see the rest of it.

maxInputLength={CONST.FORM_CHARACTER_LIMIT}

What changes do you think we should make in order to solve the problem?

  1. We can add a bigger length limit for the text input of AddressSearch instead of 50 characters, it can be 100, 200 I think.
  2. We can remove the maxInputLength.

What alternative solutions did you explore? (Optional)

N/A

@stephanieelliott
Copy link
Contributor

This is due to the character limitation to on the text box, rather than a bug. I don't think there is a real-life need to extend the number of characters we are showing. Whether it looks cut-off I think depends on how the font size set on the device. Using a Google Pixel 22 with default settings, it looks like this:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

3 participants