[HOLD FOR #25467] [$500] Split Bill - Individual chats with each participant are not created in offline mode

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Disable the internet connection in the device
2. From the global create menu +, select Split bill
3. Go through the prompt and select three participants that don't have a existing group and 1:1 conversations, and submit the request

Expected Result:

Besides group chat also individual chats with each participant should be created

Actual Result:

Individual chats with each participant are not created

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.61-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6185035_Recording__830.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0104022d629ccfb887
• Upwork Job ID: 1697679232695943168
• Last Price Increase: 2023-09-08

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0104022d629ccfb887

[melvin-bot]

Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[melvin-bot]

📣 @ayazalavi! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Rachit-pul]

Proposal

Please re-state the problem we are trying to solve

When splitting a bill while in offline mode, Besides group chat, individual chats with each participant should be created as well.

What is the root cause of this problem?

Assuming individual chats are created when online as mentioned in the problem statement. This can be due to 2 reasons-

1. There is a different logic which is executed in case of offline mode which does not have the create individual chats functionality implemented.
2. In offline mode, individual chats are failing altogether.

In case this behaviour is also present in online mode, it narrows down to the first scenario and will be a straightforward fix.

What changes do you think we should make in order to solve the problem?

To begin, I would check the code for case#1 and test the creating individual chat functionality in offline mode. With these tests I would be sure about which scenario we face.

For 1, Simply adding the logic for creating individual chats would suffice. If individual chats fail to be created in offline mode we would need to take a deeper look to figure out if it is possible to create them. If yes, I will add that functionality.

Thanks!
Rachit Pulhani

Upwork Profile Link:
https://www.upwork.com/freelancers/~01167d0

[melvin-bot]

📣 @Rachit-pul! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[ayazalavi]

Contributor details
Your Expensify account email: ayaz.alavi@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/ayaz?viewMode=1

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[jjcoffee]

Hey @ayazalavi and welcome! 👋 Please ask questions that are not related to the issue on Slack - it helps to keep things readable here.

[jjcoffee]

@ayazalavi Please see the "Expected result" section in the issue description.

Besides group chat also individual chats with each participant should be created

@Rachit-pul Thanks for your proposal! As it stands the proposal needs more detail in both the RCA (where is the issue in the code and why is it an issue) and the solution (what part of the code would you change).

[CortneyOfstad]

@jjcoffee ^^^ TIA!

[jjcoffee]

@ayazalavi I'm unsure if your RCA is correct. How would you explain that the behaviour only occurs in offline mode? Your solution is also unworkable as that logic cannot be removed.

Side-note: please copy links to the relevant code blocks rather than adding screenshots. GitHub will automatically render it as a code preview, see here for more info.

Meanwhile, open to other proposals!

[ayazalavi]

@jjcoffee please look at my updated proposal. thanks

[jjcoffee]

@ayazalavi Your RCA doesn't explain why the behaviour only happens whilst offline. If you're interested in digging deeper, it might help to read into the offline-first patterns used in the app.

@CortneyOfstad do you reckon we can increase the bounty here to get some more proposals?

[CortneyOfstad]

No update yet

[CortneyOfstad]

No update yet

[CortneyOfstad]

No update yet

[CortneyOfstad]

@jjcoffee it appears that #25467 has been closed. Anything we need to do on this side?

[CortneyOfstad]

I'm heading OoO until Oct. 25, so reassigning BZ to keep an eye on things while I'm gone 👍

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jjcoffee]

This can be removed off hold since that PR has been merged.

[melvin-bot]

@puneetlath, @CortneyOfstad, @jjcoffee Eep! 4 days overdue now. Issues have feelings too...

[puneetlath]

@jjcoffee should we remove the hold on this? Or is this now fixed?

[jjcoffee]

@puneetlath Unable to repro on latest staging v1.3.91-6 so I think we're good to close!

[puneetlath]

Great! Thanks @jjcoffee 😄