[HOLD for payment 2024-01-24] Mweb-Compose-(*&~) not applied for multiline-quote message&edit compose of (_),displays extra lines

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Open a report
3. Enter a multiline message, in that single quote(>) message include.
4. For message in above format, apply markdown ~, *&_.
5. Send the each type of markdown message seperately
6. Long press the message sent
7. Tap edit comment

Expected Result:

When user applies markdown (~, *&_) for a multiline message with quote message, markdown must be applied correctly.
In edit compose box, all messages should be in the same format in which it was sent.

Actual Result:

When user applies markdown (~ , &_ ) for a multiline message with quote message, markdown not applied correctly for bold and strikethrough(& ~ ), and correctly applied only for italic markdown.
In edit compose box, all messages should be in the same format in which it was sent.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.65-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6191038_markdown.mp4

Bug6191038_edit_mark.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01236cf31874b5d2bb
• Upwork Job ID: 1701592423306964992
• Last Price Increase: 2023-09-19

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

@johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01236cf31874b5d2bb

[melvin-bot]

Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.

[johncschuster]

Triaged

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[parasharrajat]

We are trying to block these wrong use of nested rules. #27208

[cubuspl42]

In this state, this issue contributes to the overall misunderstanding. It's the opposite, inline syntax (like emphasis or strikethrough, ~/_/*) effectively applied to a block (in this case, a quote block) is an unexpected result.

[s77rt]

Can we put this on hold for #27208? cc @johncschuster

[melvin-bot]

@johncschuster, @s77rt Whoops! This issue is 2 days overdue. Let's get this updated quick!

[s77rt]

Not overdue. Let's put this on hold

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[johncschuster]

Just put it on hold.

[melvin-bot]

⚠️ Invalid email. Please make sure to create an Expensify account with this email first here.

[byte1012]

Contributor details
Your Expensify account email: kelleyaquilino@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01f484b51cfedb480a

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Bump expensify-common to not apply Italic marckdown for multiline-quote message #33396

If no regressions arise, payment will be issued on 2024-01-24. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment (Needs manual offer from BZ)
• @byte1012 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified : fix: keep consistency with backend email validation expensify-common#566
• The offending PR has been commented on: fix: keep consistency with backend email validation expensify-common#566 (comment)
• A discussion in #expensify-bugs has been started: Not needed
• Determine if we should create a regression test for this bug: No. We have added tests to expensify-common to prevent the bug from resurfacing again

[byte1012]

@puneetlath @johncschuster
It looks like regression period is ended
Could you check payment please ?

[puneetlath]

@johncschuster is the BZ on this one and will take care of it. @johncschuster will you be able to pay it out today?

[byte1012]

@johncschuster could you send me offer on upwork ?

[byte1012]

@puneetlath @johncschuster
Friendly bump !
@puneetlath could you do it instead ? Looks like @johncschuster is not available

[johncschuster]

Sorry I missed your pings, @byte1012! I'll take care of it right now.

[byte1012]

@johncschuster Thanks
Let me know once you send offer on upwork

[johncschuster]

@byte1012 @s77rt the offer has been sent! Can you accept that?

(Job here)

[byte1012]

@johncschuster Offer accepted !

[s77rt]

@johncschuster Accepted! Thanks!

[byte1012]

@johncschuster Friendly Bump
Could you check upwork please ?

[byte1012]

@johncschuster friendly bump
can you please finish contract on upwork ? or do we wait for other ?

[byte1012]

@puneetlath could you please ping @johncschuster to check if he is available ?

[johncschuster]

Ah, sorry team. I've been struggling with keeping up with my notifications. I'm working on this now.

[johncschuster]

Payment has been issued! 🎉