[$2000] Android -Scan- Parent message not automatically updated to [Deleted] when deleted

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to + > Request money > Scan > Take a pic of the receipt
2. Once uploaded, add an amount. (very important)
3. Verify you receive amount changed message on the bottom of the page
4. Click on the 3 dots and attempt to delete it
5. Verify that the parent message does not automatically update to [Deleted]

Expected Result:

When the parent message is deleted, it should automatically update to [Deleted]

Actual Result:

Parent message is not automatically updated to [Deleted]

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.66.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Upload-unable.to.Delete.mp4

Screen_Recording_20230908_161343_New.Expensify.mp4

Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693868591788509

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a605ed983b7c2031
• Upwork Job ID: 1700244152320290816
• Last Price Increase: 2023-10-02

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a605ed983b7c2031

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[bfitzexpensify]

Agreed this should be external. Not sure why melv assigned both you and I, @CortneyOfstad, but I'm happy to take this one

[parasharrajat]

The Expected behavior is not how our thread reports work. @bfitzexpensify I feel this is something that we should clarify first before we look for proposals.

[bfitzexpensify]

@parasharrajat do you have a little more context on that? Is the expected behaviour that we don't remove historical messages upon deletion? If so, I think we would classify this as not being a bug and close the issue.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[parasharrajat]

My thought was that even if the parent message of the thread is deleted, it does not delete child messages in the thread.

IMO, the same thing applies in this case. This is how it will be shown in the parent IOU report chat.

---

But I noticed something the chat title does not change to [Deleted message] immediately. It is changed only after the message is posted in the same thread.

---

Thus I asked you to clarify the expected behaviour. Because the mentioned expected behavior is wrong.

[parasharrajat]

@bfitzexpensify Thoughts.

[bfitzexpensify]

Thanks for the clarification. You're right in that the expected behaviour doesn't match how other deleted parent messages work. It does still seem like there might be something to fix here (ensuring the parent message is updated to [Deleted]).

So, how does this sound:

We update the action performed to this:

1. Go to + > Request money > Scan > Take a pic of the receipt
2. Once uploaded, add an amount. (very important)
3. Verify you receive amount changed message on the bottom of the page
4. Click on the 3 dots and attempt to delete it
5. Verify that the parent message does not automatically update to [Deleted]

With an expected behaviour of:

When the parent message is deleted, it should automatically update to [Deleted]

[parasharrajat]

Yeah, That sounds good. It will be better to change the title and actual result as well.

[melvin-bot]

@parasharrajat @bfitzexpensify this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

Current assignee @parasharrajat is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot]

@parasharrajat, @bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[bfitzexpensify]

@parasharrajat have you had a chance to review this?

[bfitzexpensify]

friendly bump @parasharrajat

[parasharrajat]

Missed it. I will get it tomorrow.

[parasharrajat]

Okay, both proposals are very similar. Now the first question would be why these internal messages are not counted in visibleChilds. Maybe because these are only visible to the owner. Let me find more info around this.

[shubham1206agra]

@parasharrajat Maybe this

But when we change anything for the money request, such as description, amount, etc., it does not increase the amount of childVisibleActionCount due to the fact that someone created a money request by mistake and wants to delete it. After deletion, it should not show the request in the favour that the user just changed the parameter of the request, not anything useful is inside it.

[shubham1206agra]

@parasharrajat I think this has been taken care of already in #28214

[melvin-bot]

@parasharrajat, @bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[parasharrajat]

Testing.

[melvin-bot]

@parasharrajat, @bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[bfitzexpensify]

How did your testing go @parasharrajat?

[parasharrajat]

Yup. This is gone. @bfitzexpensify

[s-alves10]

@parasharrajat

It looks like the title in LHN and the header of the transaction thread were fixed already
Here is my question:
After deleting the iou request, LHN title and the header are changed to [Deleted request], but iou report shows nothing though there exists the transaction thread in the LHN.

I thought we should show [Deleted request] in the iou report as well like

Let me know what the expected behavior is
Thank you

[parasharrajat]

That is a different issue and being fixed ATM.

[bfitzexpensify]

Yup. This is gone. @bfitzexpensify

Great, thanks @parasharrajat. Closing this out.