-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Web - Delete option stays after deleting an IOU and if clicked again RBR without any way to remove it #27071
Comments
Triggered auto assignment to @isabelastisser ( |
Job added to Upwork: https://www.upwork.com/jobs/~015fcf45f4a3f7aaa3 |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to @isabelastisser ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?We're not checking if an IOU action is deleted here. What changes do you think we should make in order to solve the problem?We need to update the condition here to:
The value of
What alternative solutions did you explore? (Optional)None Note This might not be related to this issue strictly, but I think it is worth noting. |
I think this is dupe of #26019. |
Yep. That's correct. Let's close this @isabelastisser! |
thanks @allroundexperts ! Closing. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
There should not be a delete option after user has already deleted the IOU and an RBR should not appear without any way to remove it
Actual Result:
There is a delete option after user already deleted an IOU and an RBR shows up on LHN without any way to remove it if user clicks on the delete option again after deleting it the first time
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.66.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
2023-09-04.19.40.50.1.mp4
Recording.428.mp4
Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693845904666219
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: