[$500] Web - Delete option stays after deleting an IOU and if clicked again RBR without any way to remove it

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Send a money request
2. Click on the IOU preview component twice to get into the transaction thread
3. Click on the merchant field and update it by adding something and saving
4. Click on the three dots at the top right corner and click on delete
5. Click on the three dots at the top right corner again and click on delete again
6. Observe the RBR on LHN

Expected Result:

There should not be a delete option after user has already deleted the IOU and an RBR should not appear without any way to remove it

Actual Result:

There is a delete option after user already deleted an IOU and an RBR shows up on LHN without any way to remove it if user clicks on the delete option again after deleting it the first time

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.66.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-09-04.19.40.50.1.mp4

Recording.428.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693845904666219

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015fcf45f4a3f7aaa3
• Upwork Job ID: 1700259629186359296
• Last Price Increase: 2023-09-08

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015fcf45f4a3f7aaa3

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @isabelastisser (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Delete option still visible after deleting an IOU request

What is the root cause of that problem?

We're not checking if an IOU action is deleted here.

What changes do you think we should make in order to solve the problem?

We need to update the condition here to:

shouldShowThreeDotsButton={isActionOwner && !isSettled && !isDeleted}

The value of isDeleted can be computed using the following:

    const isDeleted = ReportActionsUtils.isDeletedAction(parentReportAction);

What alternative solutions did you explore? (Optional)

None

Note
If there is no message in a IOU request page, when the request is deleted, we just redirect the user to the IOU report page. However, if a message exists in the IOU request report, then we don't redirect and instead the report stays visible. This makes sense when the message is NOT a system message / whisper. I think, for system messages, we should have the same behaviour as we have when there is no message in a IOU request. In order to do this, we should modify this condition, such that shouldDeleteTransactionThread returns true if all messages in an IOU request are system messages.

This might not be related to this issue strictly, but I think it is worth noting.

[dukenv0307]

I think this is dupe of #26019.

[allroundexperts]

Yep. That's correct. Let's close this @isabelastisser!

[isabelastisser]

thanks @allroundexperts ! Closing.