Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [HOLD for payment 2023-10-02] No way to create new room even from policyRoom beta enabled account #27094

Closed
1 of 6 tasks
lanitochka17 opened this issue Sep 9, 2023 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@lanitochka17
Copy link

lanitochka17 commented Sep 9, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to FAB menu while you have the beta active
  2. Click on 'Send Message'
  3. Notice that you don't see the option to create room

Expected Result:

You can select Create Room

Actual Result:

The Create Room button does not show up

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Desktop

Version Number: 1.3.64-0 PR:25564

Reproducible in staging?: No

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6194479_Recording__6187.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c2bbc554a9b89f77
  • Upwork Job ID: 1709985526319775744
  • Last Price Increase: 2023-10-05
@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 13, 2023
@kbecciv
Copy link

kbecciv commented Sep 20, 2023

Linked PR #25564

@thienlnam thienlnam changed the title PR:25564 FAB - Several options are missing from the FAB menu No way to create new room even from policyRoom beta enabled account Sep 21, 2023
@thienlnam thienlnam added Daily KSv2 and removed Monthly KSv2 labels Sep 21, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Sep 21, 2023
@aimane-chnaif
Copy link
Contributor

@thienlnam PR is ready

@thienlnam thienlnam added the DeployBlockerCash This issue or pull request should block deployment label Sep 21, 2023
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Weekly KSv2 labels Sep 21, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Sep 21, 2023

Current assignee @thienlnam is eligible for the Engineering assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Sep 22, 2023
@melvin-bot melvin-bot bot changed the title No way to create new room even from policyRoom beta enabled account [HOLD for payment 2023-09-29] No way to create new room even from policyRoom beta enabled account Sep 22, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Sep 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 22, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Sep 22, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-09-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@thienlnam thienlnam removed the DeployBlockerCash This issue or pull request should block deployment label Sep 25, 2023
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Sep 25, 2023
@melvin-bot melvin-bot bot added the Weekly KSv2 label Sep 25, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-09-29] No way to create new room even from policyRoom beta enabled account [HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] No way to create new room even from policyRoom beta enabled account Sep 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 25, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Sep 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

@thienlnam, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

@thienlnam, @aimane-chnaif Eep! 4 days overdue now. Issues have feelings too...

@thienlnam
Copy link
Contributor

This is just pending payment - I realize we have no BZ member on this issue though

@melvin-bot melvin-bot bot removed the Overdue label Oct 5, 2023
@thienlnam thienlnam added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 5, 2023

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 5, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@thienlnam thienlnam changed the title [HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] No way to create new room even from policyRoom beta enabled account [HOLD for payment 2023-10-02] No way to create new room even from policyRoom beta enabled account Oct 5, 2023
@thienlnam
Copy link
Contributor

Hey @CortneyOfstad 👋 this issue is ready for payment, just a contributor payment to @aimane-chnaif for fixing the bug. I handled the review myself and applause reported the bug

@CortneyOfstad
Copy link
Contributor

No worries! Just a heads up @thienlnam, we have to add the External label in order to have the "job" created in Upwork for me to pay 👍

@CortneyOfstad CortneyOfstad added the External Added to denote the issue can be worked on by a contributor label Oct 5, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-10-02] No way to create new room even from policyRoom beta enabled account [$500] [HOLD for payment 2023-10-02] No way to create new room even from policyRoom beta enabled account Oct 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 5, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01c2bbc554a9b89f77

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 5, 2023

Current assignee @aimane-chnaif is eligible for the External assigner, not assigning anyone new.

@CortneyOfstad CortneyOfstad removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 5, 2023
@CortneyOfstad
Copy link
Contributor

@aimane-chnaif proposal has been sent in Upwork — please let me know as soon as you accept, as we can get that paid. Thanks!

@aimane-chnaif
Copy link
Contributor

aimane-chnaif commented Oct 5, 2023

Accepted thanks. Speed bonus also applies

@CortneyOfstad
Copy link
Contributor

Paid $750 total ($500 + 50% bonus) — closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

6 participants