[NEED TO PAY MIROSLAV][HOLD for payment 2023-09-27] [$500] Update Pusher-JS to the latest version

[tgolen]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Last week we were plagued by outages with PusherJS. The version of Pusher's front-end library that we use is 7.4.0 and the latest version 8.3.0 includes features to help with reconnections.

Let's update!

https://pusher.com/blog/pusher-js-updates-improved-reconnection-and-transport-caching-strategy/

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016bf83023a07f95e5
• Upwork Job ID: 1701367116062568448
• Last Price Increase: 2023-09-11
• Automatic offers:
• 0xmiroslav | Reviewer | 26633166
• pradeepmdk | Contributor | 26633169

[melvin-bot]

Triggered auto assignment to @jliexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[jliexpensify]

Chatted to Tim, and we'll get an external Contributor to work on this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016bf83023a07f95e5

[melvin-bot]

Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[pradeepmdk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update Pusher-JS to the latest version

What is the root cause of that problem?

current version is 7.4.0

App/package.json

Line 103 in bbc2342

"pusher-js": "7.4.0",

What changes do you think we should make in order to solve the problem?

upgrade to 8.3.0

i think we don't need @types/pusher-js because current pusher by default typescript support

[jliexpensify]

@pradeepmdk I'd imagine the process for this is like any other External job: @0xmiroslav will review suitable proposals and choose one.

[tgolen]

@pradeepmdk thanks for looking into it! Can you please also check the pusher-js change logs to be sure we're not getting any breaking changes that we need to be aware of?

[pradeepmdk]

App/src/libs/Navigation/AppNavigator/AuthScreens.js

Line 134 in bbc2342

cluster: CONFIG.PUSHER.CLUSTER,

cluster name is mandatory on v8.0.0 but we already have the cluster name

I think we don't have any breaking changes

Here is the change log
https://github.com/pusher/pusher-js/releases

[Rose-Miller-web-dev]

Proposal

Please re-state the problem that we are trying to solve in this issue.

you need to update pusher js package to the latest version

What is the root cause of that problem?

The old packages are in danger of being deprecated and out of support in soon, so it's a must to upgrade before that happens

What changes do you think we should make in order to solve the problem?

change the version number of pusher-js in package.json to 8.3.0 and all the references in package-lock.json to avoid conflicts in case there is a dependency between pusher and other packages

My Upwork Profile: https://www.upwork.com/freelancers/~017673dd8952981a22

[melvin-bot]

📣 @Rose-Miller-web-dev! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Rose-Miller-web-dev]

### Proposal
Please re-state the problem that we are trying to solve in this issue.

you need to update pusher js package to the latest version

### What is the root cause of that problem?
The old packages are in danger of being deprecated and out of support in soon, so it's a must to upgrade before that happens

### What changes do you think we should make in order to solve the problem?
change the version number of pusher-js in package.json to 8.3.0 and all the references in package-lock.json to avoid conflicts in case there is a dependency between pusher and other packages

Contributor details
Your Expensify account email: thisisrosemiller
Upwork Profile Link: https://www.upwork.com/freelancers/~017673dd8952981a22

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[Rose-Miller-web-dev]

### Proposal
### Please re-state the problem that we are trying to solve in this issue.

you need to update pusher js package to the latest version

### What is the root cause of that problem?
The old packages are in danger of being deprecated and out of support in soon, so it's a must to upgrade before that happens

### What changes do you think we should make in order to solve the problem?
change the version number of pusher-js in package.json to 8.3.0 and all the references in package-lock.json to avoid conflicts in case there is a dependency between pusher and other packages

Contributor details
Your Expensify account email: thisisrosemiller@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~017673dd8952981a22

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[PiyushChandra17]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update Pusher-JS to the latest version

What is the root cause of that problem?

We are using outdated version of Pusher-JS ie. 7.4.0

What changes do you think we should make in order to solve the problem?

We should update the Pusher-JS version to the latest ie. 8.3.0 via npm i pusher-js@8.3.0.

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

📣 @0xmiroslav 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @pradeepmdk 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[tgolen]

Assigning to @pradeepmdk for having the first correct proposal.

[pradeepmdk]

Pr is ready for review

[melvin-bot]

Triggered auto assignment to @luacmartins, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

🎯 ⚡️ Woah @0xmiroslav / @pradeepmdk, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @pradeepmdk got assigned: 2023-09-12 14:59:03 Z
• when the PR got merged: 2023-09-15 00:25:48 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• pusher upgrade 8.3.0 #27309

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @pradeepmdk requires payment offer (Contributor)
• @0xmiroslav requires payment offer (Reviewer)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[jliexpensify]

Payment Summary:

• Contributor: @pradeepmdk $500 + $250 bonus
• C+: @0xmiroslav $500 + $250 bonus

Upwork job

[jliexpensify]

Guessing there ism no checklist here @0xmiroslav?

[0xmiros]

Guessing there ism no checklist here @0xmiroslav?

correct. this is New Feature

[jliexpensify]

@pradeepmdk I have paid you

@0xmiroslav - have you sorted out your Upworks issues yet?

[0xmiros]

Not yet 😥

[jliexpensify]

@0xmiroslav did you want this closed too?

[0xmiros]

@0xmiroslav did you want this closed too?

yes