-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new wallet page layout #27211
Comments
Triggered auto assignment to @stephanieelliott ( |
@shawnborton I'm having difficulty finding the running money asset in DropBox. Can you help gather the assets we need here then we can make this external? Also lmk if you need help adjusting the aspect ratio on the lottie animation. Would be good to verify that before we make it external as well |
ProposalPlease re-state the problem that we are trying to solve in this issue.Implement new wallet page layout What is the root cause of that problem?It's a new feature What changes do you think we should make in order to solve the problem?
We will use and then for the children we can use This case is the same with
Each type of payment method can be wrapped in a This case is the same with What alternative solutions did you explore? (Optional) |
ProposalPlease re-state the feature request that we are trying to solve in this issue.Implement new wallet page layout What is the root cause of that problem?We're using ScreenWrapper for What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional)N/A |
I think @dukenv0307's proposal provides enough detail and LGTM, but I'm not going to make this external until we get the assets together |
I think this is the correct animation: https://www.dropbox.com/scl/fi/a6l4rf8qzj29kimy3va8o/Expensify-Fast-Money-2-121322-kjs-1.json?rlkey=yi2d3pun1syf3dzaqy6j3w10x&dl=0 |
Also just wanted to double check with @grgia so we aren't doubling up on work here, as I think maybe this one might be being worked on as part of the Expensify Card project? |
Yeah @roryabraham this is being done by Callstack as part of the card settings project #22871. Closing this as a duplicate |
(PR in progress here - https://github.com/Expensify/App/pull/26406/files) |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Open
Settings
->Wallet
Expected Result:
When you don't have an Expensify Wallet configured, it should look like this:
When you do have an Expensify Wallet configured, it should look like this:
Actual Result:
It doesn't look like that
Workaround:
n/a
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: