Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-09-27] Add Empty State Background to Thread Reports #27477

Closed
grgia opened this issue Sep 15, 2023 · 13 comments
Closed

[HOLD for payment 2023-09-27] Add Empty State Background to Thread Reports #27477

grgia opened this issue Sep 15, 2023 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.

Comments

@grgia
Copy link
Contributor

grgia commented Sep 15, 2023

Part of #19954
While we wait on fixes to our Lottie library, I will add our normal empty state background to thread reports

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b0316faf2ca5d66e
  • Upwork Job ID: 1702494328302874624
  • Last Price Increase: 2023-09-15
@grgia grgia added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff labels Sep 15, 2023
@grgia grgia self-assigned this Sep 15, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 15, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01b0316faf2ca5d66e

@melvin-bot
Copy link

melvin-bot bot commented Sep 15, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @fedirjh (Internal)

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels Sep 15, 2023
@melvin-bot melvin-bot bot changed the title Add Empty State Background to Thread Reports [HOLD for payment 2023-09-27] Add Empty State Background to Thread Reports Sep 20, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Sep 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 20, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Sep 20, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Sep 26, 2023
@grgia grgia added the NewFeature Something to build that is a new item. label Sep 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 Overdue labels Sep 29, 2023
@grgia
Copy link
Contributor Author

grgia commented Sep 29, 2023

hi @flaviadefaria! Would you please help with the C+ review payment of internal PR to @fedirjh ?

@melvin-bot melvin-bot bot added the Overdue label Oct 9, 2023
@flaviadefaria
Copy link
Contributor

Ah it seems like this never switched to daily so wasn't on my radar. Making it a daily now.

@melvin-bot melvin-bot bot removed the Overdue label Oct 9, 2023
@flaviadefaria flaviadefaria added Daily KSv2 Overdue and removed Weekly KSv2 labels Oct 9, 2023
@melvin-bot melvin-bot bot removed the Overdue label Oct 9, 2023
@flaviadefaria
Copy link
Contributor

@grgia, just to confirm, I need to pay @fedirjh $500, is that it?

@flaviadefaria
Copy link
Contributor

@grgia just waiting on your confirmation to pay this.

@flaviadefaria
Copy link
Contributor

Based on what I found in SO this payment should be $500 so actioning it now.

@flaviadefaria
Copy link
Contributor

@fedirjh offer for $500 was sent, please accept it so that I can pay you.

@fedirjh
Copy link
Contributor

fedirjh commented Oct 11, 2023

@flaviadefaria Accepted! Thank you.

@flaviadefaria
Copy link
Contributor

Paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

3 participants