[$500] [HOLD for payment 2023-09-27] Web – 2FA – App with 2FA installed crashes when trying to access 2FA menu

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Precondition: Have account with 2FA activated

1. Go to https://staging.new.expensify.com/
2. Log in with the account with 2FA activated.
3. Navigate to Settings > Security > Two Factor Authentication (2FA).

Expected Result:

Opens a page with the Disable 2FA option.

Actual Result:

Opens a crash page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows/ Chrome
• MacOS / Desktop

Version Number: 1.3.70-2

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6201341_2FA.mp4

utest-dl.s3.amazonaws.com_12102_26469_428866_6201341_bugAttachment_Bug6201341_Log.txt_X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20230915T115835Z&X-Amz-SignedHeaders=host&X-Amz-Expires=86400&X-Amz-Credential=AKIAJ2UIWMJ2OMC3UCQQ%2F.txt

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01eb040d2d26b7393f
• Upwork Job ID: 1709684287602880512
• Last Price Increase: 2023-10-04
• Automatic offers:
• situchan | Contributor | 27027045

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[situchan]

This regression came from #24316. Revert is being discussed in #27516

[situchan]

Crash log:

[joelbettner]

@situchan what is the status on the revert of #24316?

[situchan]

I was waiting for confirmation - #27516 (comment) if it's fine for me to raise revert PR

[situchan]

@joelbettner can I raise PR now?

[joelbettner]

@situchan...I think so? It looks like there is something happening with @bernhardoj. I'm having trouble following since things are split up between multiple issues/PRs.

[situchan]

working on it now

[situchan]

@joelbettner PR is ready

[thienlnam]

Merged the revert, will leave this one open so we can pay for the revert PR

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "Add focus trap to the RHP" #27559

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@joelbettner] The PR that introduced the bug has been identified. Link to the PR:
• [@joelbettner] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@joelbettner] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@joelbettner] Determine if we should create a regression test for this bug.
• [@joelbettner] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@johncschuster, @joelbettner Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@johncschuster, @joelbettner 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[johncschuster]

@joelbettner I'm confused. To whom am I issuing payment?

[johncschuster]

Ah, past me talked to Jack about this, and current me forgot 😅.

I've got this.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01eb040d2d26b7393f

[melvin-bot]

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

@johncschuster, @joelbettner, @situchan Eep! 4 days overdue now. Issues have feelings too...

[johncschuster]

Ah, I missed that you had accepted the job, @situchan. Issuing payment now.

[johncschuster]

Done!