-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-10-27] [$500] Android - Keyboard stays open when getting back to amount input page #27543
Comments
Triggered auto assignment to @sophiepintoraetz ( |
Job added to Upwork: https://www.upwork.com/jobs/~01c8a396e607bd78b9 |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to @strepanier03 ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr ( |
Proposal by: @Krishna2323 ProposalPlease re-state the problem that we are trying to solve in this issue.Android - Keyboard stays open when getting back to amount input page What is the root cause of that problem?The root cause is the use of keyboardShouldPersistTaps="always" on SectionList used in the BaseOptionsList. This property essentially dictates that the keyboard should remain open even after a tap on the screen (like selecting an any result). App/src/components/OptionsList/BaseOptionsList.js Lines 225 to 248 in bbc2342
What changes do you think we should make in order to solve the problem?We need to dismiss keyboard by using Keyboard.dismiss() before navigating with back button or navigating using confirmCurrencySelection function. App/src/pages/iou/IOUCurrencySelection.js Lines 79 to 92 in bbc2342
I also tried to dismiss the keyboard using cleanup function but it didn't worked. useEffect(() => () => Keyboard.dismiss(), []); Result |
ProposalPlease re-state the problem that we are trying to solve in this issue.The keyboard is not closed on the amount input page. What is the root cause of that problem?We are using What changes do you think we should make in order to solve the problem?We need to add App/src/pages/iou/IOUCurrencySelection.js Lines 79 to 92 in 191bda1
What alternative solutions did you explore? (Optional)NA |
While testing this the behavior I run into is that the keyboard is momentarily kept open but then closes after a second or two. I haven't been able to successfully get the keyboard to stay open. |
@strepanier03, you need to select an option that will be hidden when keyboard opens. |
@strepanier03 - FYI, if the Applause team have applied the |
While the keyboardShouldPersistTaps="always" setting does keep the keyboard open, I believe the root issue may be with React Native's input handling itself. The input component should programmatically blur and dismiss the keyboard when removing the screen. This would be a more robust solution, ensuring the keyboard doesn't remain open across different parts of the application. |
@ArekChr - are you saying that this is more of a feature request rather than a bug fix or you saying that the proposals don't encompass programatically blur and dismiss the keyboard? |
@sophiepintoraetz, I believe the root cause lies in the react-native repo. The proposal from @Krishna2323 looks good as a workaround. However, I'm still waiting for more proposals. |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@ArekChr, @sophiepintoraetz Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Still waiting on more proposals - will increase the bounty towards the end of the week if there isn't anything. |
Issue not reproducible during KI retests. (First week) |
Seems like we reproduced this, right @ArekChr ? If so, I'll remove the |
Current assignee @ArekChr is eligible for the External assigner, not assigning anyone new. |
📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app! |
@ArekChr, PR ready for review. |
🎯 ⚡️ Woah @ArekChr / @Krishna2323, great job pushing this forwards! ⚡️ The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉
On to the next one 🚀 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.87-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-27. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
|
Paid! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
The keyboard should be closed on the amount input page.
Actual Result:
The keyboard is not closed on the amount input page.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.70.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
WhatsApp.Video.2023-09-08.at.05.01.04.2.mp4
Record_2023-09-15-14-46-58_4f9154176b47c00da84e32064abf1c48.mp4
Expensify/Expensify Issue URL:
Issue reported by: @Krishna2323
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694209564341799
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: