Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Focus description cursor is not at the end position. #27678

Closed
1 of 6 tasks
kbecciv opened this issue Sep 18, 2023 · 7 comments
Closed
1 of 6 tasks

Web - Focus description cursor is not at the end position. #27678

kbecciv opened this issue Sep 18, 2023 · 7 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Sep 18, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click FAB button
  2. Click FAB button => Request money
  3. Enter amount => Next
  4. Select user or WS
  5. Click description and input multiple line => Save
  6. Click Request
  7. Click Request preview
  8. Click request item
  9. Click description, Observe that the cursor is not at the last position

Expected Result:

The cursor is at the end

Actual Result:

The cursor is at the beginning

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.71.4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-capture.-.2023-09-18T064009.572.webm
Recording.4562.mp4

Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695041832175819

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Sep 18, 2023
@kbecciv
Copy link
Author

kbecciv commented Sep 18, 2023

Proposal by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695041832175819

Proposal

Please re-state the problem that we are trying to solve in this issue.

The cursor is at the beginning when opening the edit description page

What is the root cause of that problem?

This issue comes from PR
We are allowing multiple description lines here
But we only have the focus logic on the input

onEntryTransitionEnd={() => descriptionInputRef.current && descriptionInputRef.current.focus()}

What changes do you think we should make in order to solve the problem?

We should update the logic focus using focusAndUpdateMultilineInputRange

onEntryTransitionEnd={() => focusAndUpdateMultilineInputRange(descriptionInputRef.current)}

What alternative solutions did you explore? (Optional)

N/A

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@daordonez11
Copy link
Contributor

daordonez11 commented Sep 18, 2023

I agree with @namhihi237 this is the same solution used in MoneyRequestDescriptionPage. Sorry that I missed this

cc @burczu

@0xmiros
Copy link
Contributor

0xmiros commented Sep 18, 2023

I don't think this is serious enough to mark as deploy blocker.
We're refactoring focusAndUpdateMultilineInputRange logic throughout the app in #21654.

@puneetlath
Copy link
Contributor

That makes sense to me. I'm going close this in favor of #21654. Thanks y'all.

@chiragxarora
Copy link
Contributor

yes, I've added fix for this in my PR for #21654

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants