-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web - Focus description cursor is not at the end position. #27678
Comments
Proposal by: @namhihi237 ProposalPlease re-state the problem that we are trying to solve in this issue.The cursor is at the beginning when opening the edit description page What is the root cause of that problem?This issue comes from PR
What changes do you think we should make in order to solve the problem?We should update the logic focus using onEntryTransitionEnd={() => focusAndUpdateMultilineInputRange(descriptionInputRef.current)} What alternative solutions did you explore? (Optional)N/A |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @puneetlath ( |
I agree with @namhihi237 this is the same solution used in MoneyRequestDescriptionPage. Sorry that I missed this cc @burczu |
I don't think this is serious enough to mark as deploy blocker. |
That makes sense to me. I'm going close this in favor of #21654. Thanks y'all. |
yes, I've added fix for this in my PR for #21654 |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
The cursor is at the end
Actual Result:
The cursor is at the beginning
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.71.4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
screen-capture.-.2023-09-18T064009.572.webm
Recording.4562.mp4
Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695041832175819
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: