[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-05] Category - Blank Category RHP appears when navigating to 1:1 IOU details with /edit/category

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #27459

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any 1:1 IOU details page
3. Add /edit/category to the end of the URL
4. Navigate to the modified link
   Note that it shows a blank RHP with Category header when Category is not available for 1:1 IOU

Expected Result:

RHP with not here message will show up

Actual Result:

A blank RHP with Category header shows up when Category is not available for 1:1 IOU

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.73-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6211693_bandicam_2023-09-23_18-26-53-653.1.mp4

Production:

bandicam.2023-09-23.18-33-53-215.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crash when going to /edit/category page

What is the root cause of that problem?

This issue is regression from this PR. In this PR we still use iou propsalthough this prop is removed in the PR

What changes do you think we should make in order to solve the problem?

We should use selectedCategory instead of iou.category

Result

Screen.Recording.2023-09-24.at.01.43.07.mov

[DylanDylann]

because this is deploy blocker, I can raise a quick PR with fully testing immediately

[puneetlath]

I don't think this is a deploy blocker since it requires you to navigate to a URL directly, which a user is unlikely to do.

@johncschuster @chiragsalian I'm going to take this over for y'all since it relates to wave6.

[puneetlath]

@waterim @rezkiy37 does one of y'all want to take this?

[BhuvaneshPatil]

For me the app is failing

for 1:1 request -
https://github.com/Expensify/App/assets/27822551/4624d5e7-4e24-468d-b545-ecc7df3d3ea4

for workspace request -

Screen.Recording.2023-09-24.at.11.52.22.AM.mov

Proposal

Please re-state the problem that we are trying to solve in this issue.

As mentioned in issue we are not categories, but while reproducing offline on dev, app crashed for me.
This happened for workspace request as well

What is the root cause of that problem?

The error here is that, iou is being used in CategoryPicker, but it is not defined anywhere and we using category of that variable which is not defined.

What changes do you think we should make in order to solve the problem?

My guess here is that we wanted to get IOU from onyx but we are not doing that.
To add this we need to

• Add new prop iou in CategoryPicker (also define that prop categoryPickerPropTypes)
• And get the IOU from onyx using withOnyx
• adding to this, we shall use lodashget to retrieve the properties

What alternative solutions did you explore? (Optional)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.74-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix crash on category picker #28091

If no regressions arise, payment will be issued on 2023-10-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rezkiy37 does not require payment (Contractor)
• @situchan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rezkiy37]

The PR - #28165 - is still waiting for review.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix NotFound page for categories and tags #28165

If no regressions arise, payment will be issued on 2023-10-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rezkiy37 does not require payment (Contractor)
• @situchan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[situchan]

BZ Checklist:

• 1st bug (crash)
  This came from 2 PRs which merged simultaneously into main. This is rare case but sometimes happens.
  So I'd just say "everyone make sure to pull from main & retest just before merge" and no need regression test.

• 2nd bug (blank page)
  This was caught during development of category feature.
  As category is still in beta, I think it's early yet to add regression test. And this happened only when browser url is edited manually which is edge case.

[puneetlath]

@situchan sent you an offer: https://www.upwork.com/nx/wm/offer/27148100

[situchan]

Not sure how compensation applies here.
First bug fix was requested in slack so I volunteered and raised PR
2nd bug: normal C+ review

[puneetlath]

Ah, I didn't realize there were two PRs here. I'll update the offer.

[puneetlath]

Ok updated and paid. Thanks!