Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAML SSO in NewDot - Desktop UI #28216

Closed
sakluger opened this issue Sep 26, 2023 · 15 comments
Closed

SAML SSO in NewDot - Desktop UI #28216

sakluger opened this issue Sep 26, 2023 · 15 comments
Assignees
Labels
Engineering NewFeature Something to build that is a new item. Weekly KSv2

Comments

@sakluger
Copy link
Contributor

Tracking GH issue: https://github.com/Expensify/Expensify/issues/294583
Relevant design doc section: https://docs.google.com/document/d/1xa68adybahTxucjSqvPJ2MZCZvaBoP1_vtYk5hTikGU/edit#heading=h.bkhju6ro8k33

@NikkiWines
Copy link
Contributor

Focusing on web / mweb first, then on platform specific logic

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

@sakluger, @NikkiWines Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@sakluger
Copy link
Contributor Author

sakluger commented Oct 2, 2023

No updates, @NikkiWines what's the ETA on this one? Would it still make sense to ask Infinite Red to help with this one?

@melvin-bot melvin-bot bot removed the Overdue label Oct 2, 2023
@NikkiWines
Copy link
Contributor

We're still trying to get web + mweb over the line but I'm hoping to start on it this week while I'm working 50%. I think it makes sense to open this up to contributors/agencies for all of the platform specific issues

@sakluger
Copy link
Contributor Author

sakluger commented Oct 5, 2023

According to @NikkiWines in Slack, Desktop was lumped into #28372. @NikkiWines should we add this issue's link to the PR?

@NikkiWines
Copy link
Contributor

Yep!

@NikkiWines
Copy link
Contributor

See update here

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 10, 2023
@sakluger
Copy link
Contributor Author

No updates on this one.

@melvin-bot melvin-bot bot removed the Overdue label Oct 13, 2023
@NikkiWines NikkiWines added Reviewing Has a PR in review Improvement Item broken or needs improvement. NewFeature Something to build that is a new item. Engineering and removed Improvement Item broken or needs improvement. labels Oct 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 13, 2023

Current assignee @sakluger is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 Weekly KSv2 labels Oct 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 17, 2023
@melvin-bot melvin-bot bot changed the title SAML SSO in NewDot - Desktop UI [HOLD for payment 2023-10-24] SAML SSO in NewDot - Desktop UI Oct 17, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@sakluger sakluger changed the title [HOLD for payment 2023-10-24] SAML SSO in NewDot - Desktop UI SAML SSO in NewDot - Desktop UI Oct 23, 2023
@sakluger sakluger removed the Awaiting Payment Auto-added when associated PR is deployed to production label Oct 23, 2023
@sakluger
Copy link
Contributor Author

This has the same PR as #28215, no separate payment required.

@NikkiWines
Copy link
Contributor

This is done - desktop UI is live

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering NewFeature Something to build that is a new item. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

2 participants