-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAML SSO in NewDot - Desktop UI #28216
Comments
Focusing on web / mweb first, then on platform specific logic |
@sakluger, @NikkiWines Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
No updates, @NikkiWines what's the ETA on this one? Would it still make sense to ask Infinite Red to help with this one? |
We're still trying to get web + mweb over the line but I'm hoping to start on it this week while I'm working 50%. I think it makes sense to open this up to contributors/agencies for all of the platform specific issues |
According to @NikkiWines in Slack, Desktop was lumped into #28372. @NikkiWines should we add this issue's link to the PR? |
Yep! |
See update here |
No updates on this one. |
Current assignee @sakluger is eligible for the NewFeature assigner, not assigning anyone new. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-24. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
This has the same PR as #28215, no separate payment required. |
This is done - desktop UI is live |
Tracking GH issue: https://github.com/Expensify/Expensify/issues/294583
Relevant design doc section: https://docs.google.com/document/d/1xa68adybahTxucjSqvPJ2MZCZvaBoP1_vtYk5hTikGU/edit#heading=h.bkhju6ro8k33
The text was updated successfully, but these errors were encountered: