-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-10-16] Set up preview builds for HelpDot #28531
Comments
Triggered auto assignment to @twisterdotcom ( |
Setup steps:
|
Might need ring0 help for the third step |
Created Netflify account under reactnative@expensify.com – password is in the ring3 bucket in 1P |
nvm, it can be done in config file |
Triggered auto assignment to @fukawi2 ( |
@fukawi2 There should be a pending request to configure Netlify with Expensify/App: |
Additional infra discussion: https://expensify.slack.com/archives/C094TGUTZ/p1696058736845509 |
Sounds like we might use Cloudflare instead of Netlify for this. |
Tagging in @coleaeason to help set that up - sounds like it will be easy |
@roryabraham awesome, I'll close my PR Here is the build command - |
Working on this now, should have it done today or tomorrow. |
PR is up! Builds will fail until that PR is merged. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-16. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
Thanks for the help everyone! @roryabraham we can close this issue? |
Slack context: https://expensify.slack.com/archives/C01GTK53T8Q/p1695766723259829
cc @rushatgabhane
Problem
We can easily make mistakes when adding articles to HelpDot. And testing locally requires setup.
To ensure nothing is breaking, an engineer has to review the PR when adding articles to HelpDot. This takes our precious time!!
Why this is important
We want HelpDot to be mostly maintained by non-engineers. They can create an adjust articles just by creating markdown files. However, they cannot actually test or preview their changes without a dev environment setup.
Solution
Deploy helpsite PR previews to netlify. It generates a deploy preview for PRs. https://docs.netlify.com/site-deploys/deploy-previews/
The text was updated successfully, but these errors were encountered: