[$500] Connect Bank account - Crash when completed adding BA manually

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Login with any account
3. Go to Settings -> Workspaces -> Open any WS
4. Tap on Bank account -> Confirm the changing currency to USD -> Connect manually
5. Complete process adding BA manually using the "Pending State Withdrawal Account" credentials

Expected Result:

No crash when completed adding BA manually

Actual Result:

Crash when completed adding BA manually

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.77-3

Reproducible in staging?: Yes

Reproducible in production?: N/a

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6224521_1696418117930.Record_2023-10-04-00-50-57_4f9154176b47c00da84e32064abf1c48.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019ebda629d7c18f15
• Upwork Job ID: 1709642119622356992
• Last Price Increase: 2023-10-11
• Automatic offers:
• Pujan92 | Contributor | 27024773

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crash for Validate screen in bank account setup flow, It is not crashing for me in ios/android but shows a console warning in the web and it might be the reason for crash.

What is the root cause of that problem?

Seems testId is set to undefined as we don't have value displayName here.

App/src/pages/ReimbursementAccount/ValidationStep.js

Line 134 in 24aa7c1

testID={ValidationStep.displayName}

Kind of regression as that page mentioned here but somehow missed in the PR

What changes do you think we should make in order to solve the problem?

Set displayName which won't pass undefined to testId.

ValidationStep.displayName = 'ValidationStep';

App/src/pages/ReimbursementAccount/ValidationStep.js

Lines 230 to 232 in 24aa7c1

	ValidationStep.propTypes = propTypes;
	ValidationStep.defaultProps = defaultProps;

Note: I skipped the onfido flow step to reach the last step as the crash happened after 4th step. For me it is not crashing

Seems more pages need to be reconsidered as the below list of components is missed within that propsoal.

1. AddPersonalBankAccountPage
2. SearchPage
3. RequestorOnfidoStep
4. WorkspaceInviteMessagePage
5. ShareCodePage
6. ReimbursementAccountPage
7. ContactMethodDetailsPage
8. WorkspaceInviteMessagePage

[joekaufmanexpensify]

@srikarparsi will you have a chance to look into this today?

[srikarparsi]

Yeah, taking a look now

[srikarparsi]

Hey @Pujan92, I'm not able to reproduce this error for some reason but I see your screenshot and you're right in the ValidationStep and many others don't have DisplayName set. Will you have time to work on this today?

[Pujan92]

I am also not seeing the crash but I can work for fixing the display name set part today.

[srikarparsi]

Awesome thanks, let me know when you have the PR ready to review.

[melvin-bot]

Current assignee @joekaufmanexpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019ebda629d7c18f15

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

[Pujan92]

@srikarparsi Plz review the PR once.

[mountiny]

After discussion in slack thread, I am demoting this to normal bug as no contributor was able to reproduce actually.

This can still be an issue though so leaving this open

[joekaufmanexpensify]

@Pujan92 I see you closed your PR in favor of #28334 . Does that mean this issue is a dupe, and we can close it?

[Pujan92]

No @joekaufmanexpensify, my findings were not directly related to this issue. Based on that we have reopened this issue for contributors, so I believe we should not close this issue yet.

[joekaufmanexpensify]

Ah, okay got it.

[joekaufmanexpensify]

I was able to reproduce. Discussing here.

[joekaufmanexpensify]

Not overdue

[joekaufmanexpensify]

Applause was able to reproduce as well

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[joekaufmanexpensify]

Pending proposals

[srikarparsi]

Still pending proposals

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[joekaufmanexpensify]

I'll try to reproduce today again. If I can't I will close!

[joekaufmanexpensify]

No longer reproducible for me. Closing!