[HOLD for payment 2023-12-12] [HOLD for payment 2023-11-06] [$500] [Form Provider Refactor] RoomNamePage and WorkspaceNewRoomPage

[luacmartins]

Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/pages/settings/Report/RoomNamePage.js and src/pages/WorkspaceNewRoomPage.js

cc @kowczarz

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f44006a9fb9bd1d3
• Upwork Job ID: 1709705843518455808
• Last Price Increase: 2023-10-05

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f44006a9fb9bd1d3

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @allroundexperts (Internal)

[kowczarz]

Hello! I'm Kamil Owczarz from Software Mansion, the expert agency and I would like to work on this task.

[melvin-bot]

Current assignee @allroundexperts is eligible for the External assigner, not assigning anyone new.

[NicMendonca]

@kowczarz any progress on this one? Thanks!

[kowczarz]

Hey, probably tomorrow I will prepare a PR.

[kowczarz]

I'm working on it.

[kowczarz]

Since it's pretty similar case as here #28879 (comment), I will handle RoomNameInput and WorkspaceNewRoomPage as well in this issue.

[kowczarz]

#28821 Blocks the issue, I think as soon as it will be merged I will be able to prepare a working PR.

[melvin-bot]

@luacmartins, @NicMendonca, @allroundexperts, @kowczarz Whoops! This issue is 2 days overdue. Let's get this updated quick!

[NicMendonca]

Waiting for this to merge: #28821

[JmillsExpensify]

@NicMendonca Mind updating the payment summary?

[NicMendonca]

• Reporter: N/A
• Contributor: @kowczarz - payment not required
• Contributor + @allroundexperts - $250 - paid via Expensify

[JmillsExpensify]

$250 payment approved for @allroundexperts based on summary above.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.7-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Form Provider Refactor] RoomNameInput fixes #30996

If no regressions arise, payment will be issued on 2023-12-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment via manual request.
• @kowczarz does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

This issue has not been updated in over 15 days. @luacmartins, @NicMendonca, @allroundexperts, @kowczarz eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[NicMendonca]

we're all set here!