[$500] [DISTANCE] LOW: Distance IOU - Addresses are cleared after navigating between address and confirmation page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #26307

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Go to + > Request money > Distance
3. Enter start and finish address, then proceed all the way to the confirmation screen
4. Return back to the Distance address page
5. Proceed to the final confirmation page
6. Back to Distance address page

Expected Result:

The addresses that are entered are preserved

Actual Result:

The addresses that are entered are cleared

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.78-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6225738_1696503258441.20231005_181639.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e02f1e0185235867
• Upwork Job ID: 1735782081162653696
• Last Price Increase: 2023-12-15

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kosmydel]

Hey, I checked it since it was found when checking my PR. Just want to say, that this issue also occurs in production, so it's probably not related to my PR.

Video

Screen.Recording.2023-10-05.at.16.52.32.mov

[AmjedNazzal]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance IOU - Addresses are cleared after navigating between address and confirmation page

What is the root cause of that problem?

In multiple places through the money request components we are using the following logic:

const shouldReset = props.iou.id !== moneyRequestId;
if (shouldReset) {
    IOU.resetMoneyRequestInfo(moneyRequestId);
}

This logic becomes problematic when IOU.navigateToNextPage is being called by the navigateToNextPage function and in MoneyRequestParticipantsPage as it repetedly checks shouldReset within it's useEffect but the issue here is that these two don't always have access to the updated reportID and so when the user chooses where the distance request will be shared, iou.id becomes "request" + the reportID but for the components I mentioned since they don't have access to that reportID the value of moneyRequestId will remain just "request" and so they will call IOU.resetMoneyRequestInfo

What changes do you think we should make in order to solve the problem?

We can either make some changes to make sure that these components are having the most recent reportID or we can add a safeguard check to make sure that a reportID does indeed exist before checking if it equals iou.id

In MoneyRequestParticipantsPage:

if(reportID.current){
    const moneyRequestId = `${iouType.current}${reportID.current}`;
    const shouldReset = iou.id !== moneyRequestId && !isNewReportIDSelectedLocally.current;
    if (shouldReset) {
    IOU.resetMoneyRequestInfo(moneyRequestId);
    }
}

In IOU.navigateToNextPage:

if(report.reportID){
    if (shouldReset) {
        resetMoneyRequestInfo(moneyRequestID);
    }
}

There are a bunch of other possible options we can do here but the general idea is to not allow calling resetMoneyRequestInfo unless we do some control regarding reportID

Result

Screen.Recording.2023-10-05.at.7.10.00.PM.mov

[neil-marcellini]

I think this will be fixed by #26538 (comment), so I'm holding it on that.

[melvin-bot]

@johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[johncschuster]

Still holding. Not overdue.

[johncschuster]

Still holding

[johncschuster]

Shall we bump to Weekly while we wait, @neil-marcellini?

[johncschuster]

Bumping to Weekly

[johncschuster]

Still holding

[johncschuster]

No update. We're still holding on #26538 (comment)

[johncschuster]

Still holding

[johncschuster]

Looks like we're still on hold

[dylanexpensify]

off hold @johncschuster! 🎉

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e02f1e0185235867

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[johncschuster]

I will be OOO starting Monday, December 18, and will return Tuesday, January 2.

Current status:
This issue was just taken off hold and assigned to a C+ member to start reviewing proposals.

If this issue is open when I'm back from OOO, I'll take it back over. Thank you!

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[paultsimura]

Not reproducible after the IOU flow refactoring

[AmjedNazzal]

This has been resolved using underscore from DefinitelyTyped

[jjcoffee]

@muttmuure We can close this!

[johncschuster]

I happened to be traipsing through to finish up my OOO checklist. I'll go ahead and close it. Thanks, @jjcoffee!