[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] The "Merchant" title and page briefly appear instead of the distance title and page

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on the "+" button or go to the expense room
2. Navigate to Request money > Distance
3. Select Start and Finish points and proceed with the request
4. Quickly go to the distance request detail page and click on “Merchant”

Expected Result:

The "Merchant" title and page should not be displayed even for a brief moment when requesting money for a distance

Actual Result:

The "Merchant" title and page are briefly shown instead of the distance page

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native - Emulator not working and didn't attach video
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop - missing since desktop is crashing

Version Number: 1.3.78-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.5.mp4

screen-recording-2023-10-05-at-14053-am_9He1v6uv.mp4

Screen.Recording.2023-10-05.at.1.56.17.AM.mov

Screen.Recording.2023-10-05.at.1.53.59.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696452613289539

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e052b456797c7dfb
• Upwork Job ID: 1710009572771434496
• Last Price Increase: 2023-10-05

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e052b456797c7dfb

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "Merchant" title and page briefly appear instead of the distance title and page

What is the root cause of that problem?

We are not checking the transaction is distance or not to display the title accordingly

App/src/pages/EditRequestMerchantPage.js

Line 44 in 1eafc7d

title={translate('common.merchant')}

What changes do you think we should make in order to solve the problem?

We should add an extra prop to EditRequestMerchantPage like isDistanceRequest to know if the request is distance or not. Use this prop to display the title

const title = isDistanceRequest ? translate('common.distance') : translate('common.merchant')

And then on EditRequestPage page, we will pass isDistanceRequest prop into EditRequestMerchantPage

<EditRequestMerchantPage
    defaultMerchant={transactionMerchant}
    isDistanceRequest={TransactionUtils.isDistanceRequest(transaction)}
    onSubmit={(transactionChanges) => {
        // In case the merchant hasn't been changed, do not make the API request.
        if (transactionChanges.merchant.trim() === transactionMerchant) {
            Navigation.dismissModal();
            return;
        }
        editMoneyRequest({merchant: transactionChanges.merchant.trim()});
    }}
/>

What alternative solutions did you explore? (Optional)

NA

Result

Screencast.from.06-09-2023.22.03.00.webm

[neil-marcellini]

I've fixed this in #27204

Screen.Recording.2023-10-05.at.3.07.16.PM.mov

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[burczu]

Can't test it right now on current main - there is some issue with GooglePlacesAutocomplete. I'll get back to it later to check again.

[neil-marcellini]

To be clear I have a fix in that PR I linked above.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Show eReceipts for distance requests #27204

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @burczu does not require payment (Contractor)
• @ayazhussain79 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@burczu] The PR that introduced the bug has been identified. Link to the PR:
• [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@burczu] Determine if we should create a regression test for this bug.
• [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[adelekennedy]

@neil-marcellini @burczu the only payout due here is the reporting bonus - is that correct?
Payouts due:

Issue Reporter: $50 @ayazhussain79 (Upwork)

Eligible for 50% #urgency bonus? N

Upwork job is here.

[adelekennedy]

@ayazhussain79 sent you an offer

[ayazhussain79]

@adelekennedy offer accepted, Thank you

[melvin-bot]

@burczu, @neil-marcellini, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[adelekennedy]

Paid! @burczu does the bugzero checklist above apply here? If not I will close the issue

[neil-marcellini]

Bump @burczu

[neil-marcellini]

@adelekennedy don't you want credit for your BZ work here? I'm re-assigning you as the issue owner.

[melvin-bot]

@burczu, @neil-marcellini, @adelekennedy Huh... This is 4 days overdue. Who can take care of this?

[adelekennedy]

@burczu please reopen this issue if the checklist is needed - otherwise closing since payments have been made