Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Distance - Error shows up when location access is limited to approximate location #29008

Closed
1 of 6 tasks
lanitochka17 opened this issue Oct 6, 2023 · 10 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 6, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #26546

Action Performed:

  1. Launch New Expensify app
  2. Go to + > Request money > Distance > Start
  3. Tap Use current location
  4. Select 'Approximate location' and 'While using the app'
  5. If there is no error, go to Finish point > Use current location
  6. Select 'Keep approximate location'

Expected Result:

App should be still able to detect the location because the location access is still given

Actual Result:

App is unable to detect user location. An error shows up
Error message - We were unable to find your location, please try again or enter an address manually

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.79-3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6227638_1696603467117.Screen_Recording_20231006_204230_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 6, 2023

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 6, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

OSBotify commented Oct 6, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Oct 6, 2023

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@huzaifa-99
Copy link
Contributor

huzaifa-99 commented Oct 6, 2023

The error indicates that the location lib wasn't able to get the app "approx location", we don't store it manually and it is managed by the @react-native-community/geolocation lib internally. Same with "precise location", but its more reliable as it uses the phone sensors to get the location, "approx" will use internet/cell-towers to get location.

I don't think this is issue but plz let me know. Thanks

cc: @hayata-suenaga @luacmartins

@luacmartins
Copy link
Contributor

luacmartins commented Oct 6, 2023

I agree this is not a blocker and maybe not an issue that we can solve on our end. @neil-marcellini @tgolen curious for your thoughts

@luacmartins luacmartins added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 6, 2023
@hayata-suenaga
Copy link
Contributor

I agree with @huzaifa-99 that this is not an issue. I'll wait for @neil-marcellini 's confirmation before closing the isuse.

@melvin-bot melvin-bot bot added the Overdue label Oct 9, 2023
@jasperhuangg
Copy link
Contributor

Agree that this shouldn't be a blocker, I don't think there's anything we can do.

Maybe we can update the error message to specify that if you're on Android you should allow precise location tracking.

@melvin-bot
Copy link

melvin-bot bot commented Oct 10, 2023

@luacmartins, @MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@luacmartins
Copy link
Contributor

Cool, gonna close this issue then since it's not actually an issue that's actionable by us. Thanks for the input everyone!

@melvin-bot melvin-bot bot removed the Overdue label Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

7 participants