[$500] Distance - Clicking on Use current location when suggestion list is open does not trigger action

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #26546

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Go to + > Request money > Distance
3. Click Start
4. Enter any address so that the suggestion list shows up
5. Click on Use current location

Expected Result:

Since the cursor displays as a hand when hovering over 'Use current location', clicking on it should trigger the app to detect user's current location

Actual Result:

Clicking on 'Use current location' does not trigger the intended action of the button when the suggestion list is open.
On Android, it works without issue when the suggestion list is open

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• Windows / Chrome
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.79-3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6227689_1696606124772.20231006_213541__1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cd6068abd5a84d8a
• Upwork Job ID: 1710364184113389568
• Last Price Increase: 2023-10-13

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[huzaifa-99]

This doesn't look like an issue. When we open the suggestion list and click outside anywhere the list will close (on web).

cc: @hayata-suenaga @deetergp

[deetergp]

@lanitochka17 You can't say that clicking on "Use current location" works in production if that link does not exist on production. Not a deploy blocker, but I agree that clicking on the link should work as intended, rather than simply trigger hiding the list when clicking outside it.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cd6068abd5a84d8a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[huzaifa-99]

Not a deploy blocker, but I agree that clicking on the link should work as intended, rather than simply trigger hiding the list when clicking outside it.

Actually, the dropdown list is linked with the address search input, when the input loses focus we hide the list. I think we can just change the cursor on the 'use current location' button when the list is open.

[hayata-suenaga]

@huzaifa-99 doesn't clicking the "Use current lcoation" button both make the input loose focus and the onPress callback to be invoked?

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When an address suggestion list is open, clicking on "Use current location" button is not working.

What is the root cause of that problem?

The RCA here is that the "Use current location" button is located below the expanding suggestion lost. So when we click on it:

1. The list hides
2. "Press" event is executed

However, after the list hides, the button changes its location, and the press event clicks an empty space. You can prove it by, for example, simply changing the position of this button to above the waypoint search field.

What changes do you think we should make in order to solve the problem?

A simple solution is to move the "Use current location" button on top of the search field, which will make the button's position independent from the list:

current-location.mov

What alternative solutions did you explore? (Optional)

[huzaifa-99]

@huzaifa-99 doesn't clicking the "Use current lcoation" button both make the input loose focus and the onPress callback to be invoked?

In theory, it should yes, but the button doesn't get the click when the list changes position (similar to what @paultsimura mentioned)

However, after the list hides, the button changes its location, and the press event clicks an empty space.

cc: @hayata-suenaga

[hayata-suenaga]

but the button doesn't get the click when the list changes position

ah this is tricky...

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[huzaifa-99]

Since the location button is getting moved to the list (context, context), i think we can close this issue.

[jliexpensify]

Ok great, looks like @jjcoffee gave the thumbs up so closing it out.