[$500] Desktop - The upper left "Apple icons" have a faint tinted line through them

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.3.80-0

Reproducible in staging?: Y

Reproducible in production?: N, this is a new feature

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

Action Performed:

1. Open the New Expensify Desktop app
2. Sign into a valid account
3. Observe the top left corner

Expected Result:

User expects that there is no overlapping and items are spaced evenly

Actual Result:

There is a very faint green line running through the Desktop Apple icons in the upper left corner. Also, these icons are very closely displayed to the users avatar image and when there is an error message (Red dot) on the users profile, they almost overlap.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0121122693d769b021
• Upwork Job ID: 1711662396186996736
• Last Price Increase: 2023-10-10

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0121122693d769b021

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[b4s36t4]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Desktop - The upper left "Apple icons" have a faint tinted line through them

What is the root cause of that problem?

We have introduced a new global navigation in which we added a new sidebar screen which is causing this issue. Previosuly we used to have Expensify Logo and same bg color for entire LHN.

But due to recent changes we have different color for new sidebar screen and also replaced logo with some text and user's avatar.

What changes do you think we should make in order to solve the problem?

We need to increase the header gap for electron. Right now it's 12px which is serving it's purpose but to accomodate new look we need to increase the height maybe (26px?)

App/src/CONST.ts

Line 885 in d916eff

DESKTOP_HEADER_PADDING: 12,

26px gap

What alternative solutions did you explore? (Optional)

NA

[b4s36t4]

@shawnborton can you check this as it might be related to design issue.

[0xmiros]

This maybe not a deploy blocker and handled in #29057?
cc: @hayata-suenaga

[abdulrahuman5196]

This maybe not a deploy blocker and handled in #29057? cc: @hayata-suenaga

Kindly do let me know if we don't need to take this issue separately or will be handled part of other issues.

[shawnborton]

We should not be taking proposals for this, this is a known follow-up item for @adamgrzybowski

[madmax330]

Cool so we can close this @shawnborton or should I assign @adamgrzybowski ?

[shawnborton]

Let's first confirm with @hayata-suenaga - I'm not sure what our plan is for consolidating design bugs for the hybrid web project.

[jasperhuangg]

Gonna take the Deploy Blocker label off if this is a known followup

[trjExpensify]

I asked @stitesExpensify if he knew here, but I think we'll have to wait for @hayata-suenaga to confirm the plan for these design followups.

[hayata-suenaga]

This issue is consolidated to this issue. This issue was reported by Applause, so no payment is necessary for bug report.

[kosmydel]

Hey, some questions related to design here:

I'm considering the following options:

1. Increase padding on the desktop (I believe that 27px will have even paddings from the top and bottom) and change the background color of the header gap (screen).
2. Or maybe increase padding for the avatar. Downside: Avatar will no longer align with the other items at the top ("Chats" text, Search loop, etc.).

Here is what the first option looks like:

We also have to take into consideration that the Avatar displays a popup when is hovered:

Which option is the preferred one?

cc @shawnborton, @hayata-suenaga

[shawnborton]

Discussing here in Slack