IOS - LHN - Deleted offline workspace chats do not move to the bottom

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.80-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Issue found when executing PR #28987

Action Performed:

1. Open the app
2. Create a workspace and add some members
3. Turn off internet connection
4. Remove a member from the workspace
5. Navigate back to LHN

Expected Result:

The workspace chat with a member is archived and moved to the bottom

Actual Result:

The workspace chat gets archived, but it is not moved to the bottom. It stays in the same place in LHN

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Bug6232187_1696960706661.IMG_2353.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[jasperhuangg]

Don't really think we need to block deploy on this, but I do think @tsa321 should make sure that this flow works.

Looking through the tests for #28987 iOS native we're not testing to see if the LHN item for the archived workspace chat gets sorted to the bottom.

[tsa321]

I am sorry I cannot reproduce this issue in my branch:

video:

ios-native_d.mp4

also in latest main:

lsmain_d.mp4

I will investigate this further...


update:I have tried many times.... still cannot reproduce.
Is there any specific steps?

[melvin-bot]

@cead22, @strepanier03 Huh... This is 4 days overdue. Who can take care of this?

[strepanier03]

I'm also struggling to recreate this. I'm using Browserstack since I don't have an iOS physical device.

@lanitochka17 - Are you still able to recreate this following the steps exactly? Any advice you can offer @tsa321 or I?

[lanitochka17]

@strepanier03 Hello
Issue reproducible on Build 1.3.86-0

IMG_2652.MP4

[tsa321]

@lanitochka17 I am sorry if I am bothering you, but could you test for delete workspace while offline too? I cannot reproduce this issue in IOS simulator so it will be a helpful information if you could test the delete workspace while offline too.
The steps are:

1. Send a message to two random email to make this two chat go up in LHN
2. Create a workspace and add some members
3. Go to LHN
4. Turn off wifi
5. Then delete the workspace
6. Observe if the workspace chats is going to the bottom of LHN

Thank you...

[lanitochka17]

@tsa321 Hello
According your steps Workspace chats have moved down
Iphone 14 Pro Max/ios17

0-02-01-6fc7a662804cd48bc643c5ef84a0d178233bc4234984ea14eb1cc6ab448c6cb0_b36f968b3cf492ab.mp4

[tsa321]

Thank you very much @lanitochka17

the workspace chats is not moved down when user is still in offline mode:

this confirm my initial suspection that the bug is in the LHN logic area.
I think the cause is because we failed to re-render the LHN when a workspace is deleted or member of workspace is removed while offline, so no reordering happens in the LHN when offline.
This issue only happens in physical device and not in ios simulator.
I want to dig more but I don't have physical IOS device.

cc: @mountiny @burczu

[strepanier03]

I'm also stuck without a physical iOS device.

[mountiny]

I think we can close this issue @cead22

[melvin-bot]

@cead22, @strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!