[$500] When selecting the Finish point the Start and Finish points are grayed out for a moment with the "Next" button

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.84-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696433219544139

Action Performed:

1. Click on the "+" button.
2. Go to Request money > Distance.
3. Select Start and then the Finish point.
4. Observe that both Start and Finish points are grayed out with the "Next" button.

Expected Result:

Start and Finish points should not be grayed out when selecting the Finish point

Actual Result:

Start and Finish points are grayed out with the "Next" button when selecting the Finish point.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native - not provided
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2023-10-04.at.8.30.05.PM.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

screen-recording-2023-10-04-at-81717-pm_9dgGLlal.mp4

Recording.69.mp4

MacOS: Desktop

screen-recording-2023-10-04-at-82806-pm_SYVHUjgL.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01acf4f61c03542500
• Upwork Job ID: 1712970654951510016
• Last Price Increase: 2023-10-27

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01acf4f61c03542500

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• When selecting the Finish point the Start and Finish points are grayed out with the "Next" button

What is the root cause of that problem?

• Currently, we disable the Start and Finish points when the route is loading, that leads to the bug " When selecting the Finish point the Start and Finish points are grayed out with the "Next" button"
  

  App/src/components/DistanceRequest/index.js

  Line 172 in 25f7ac1

  disabled={isLoadingRoute}

• The above logic is added to commit which fixes the issue Bug2: flicker issue (showing old order for a brief moment). It disables the items of draggable list when the route is reloading.

What changes do you think we should make in order to solve the problem?

• We should only prevent the items from being dragged when the route is loading, other methods like clicking on items to edit waypoints, ... still be allowed. We can do it by:
• Update the DraggableList from

  App/src/components/DraggableList/index.tsx

  Line 91 in 4078503

  <Draggable

  
  to

  <Draggable isDragDisabled={props.isDragDisabled} ... />

• Then when using DraggableList, update
  

  App/src/components/DistanceRequest/index.js

  Line 157 in 4078503

  <DraggableList

  
  to

<DraggableList isDragDisabled={isLoadingRoute} ... />

• Also we need to remove the isDragDisabled={isLoadingRoute} from

  App/src/components/DistanceRequest/index.js

  Line 172 in 4078503

  disabled={isLoadingRoute}

What alternative solutions did you explore? (Optional)

• NA

[narefyev91]

@mallenexpensify not sure that it's a bug. When user select finish route - we need to wait until mapbox will prepare route and show it. Allowing edit during building route may cause unpredictable bugs like not correct route show, slow down map render and etc.

[mallenexpensify]

@m-natarajan, can you please provide screenshots or vids in the OP? Here's what I'm seeing which doesn't seem like a bug , not looks particularly greyed out

[melvin-bot]

@mallenexpensify, @narefyev91 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mallenexpensify]

Waiting on feedback from above.

@m-natarajan, can you please provide screenshots or vids in the OP? Here's what I'm seeing which doesn't seem like a bug , not looks particularly greyed out

[m-natarajan]

@mallenexpensify Videos are added to iOS native, MacOS: Chrome / Safari and MacOS: Desktop.

I am adding video here, at the timeline 08sec both waypoints are grayed out for a brief moment. Now "Next" button is not disabled.

Recording.145.mp4

[narefyev91]

@mallenexpensify like this:

[mallenexpensify]

I feel like this looks more like a loading process than a significant bug. Like, the app is quickly processing the addresses before producing the map.

Is there something I'm maybe missing here? I'm leaning towards closing this as being too minor to fix.

Thanks for posting the vid and screenshot @m-natarajan and @narefyev91

[mallenexpensify]

Thanks for the comment @DylanDylann , I'm checking internally since I'm not well-versed in distance-related bugs and features.

[melvin-bot]

@mallenexpensify @narefyev91 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@mallenexpensify, @narefyev91 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mallenexpensify]

I posted internally and got back

Yeah this definitely does not look like a bug, we’re generating the route to show on the map

Going to close