[PAID] IOS - Send message - Label not show on tab selector

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: Dev v1.3.83-10
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697210216244469

Action Performed:

1. Click FAB button
2. Click send message
3. Observe that the label on the tab selector does not appear

Expected Result:

It show label on selector tab

Actual Result:

The label on the selector does not appear

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a781f41a1aa70899
• Upwork Job ID: 1713215578534891520
• Last Price Increase: 2023-10-14

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a781f41a1aa70899

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[ikevin127]

Proposal

Please re-state the problem that we are trying to solve in this issue.

It show label on selector tab icon and label.

What is the root cause of that problem?

It is a regression from PR #27660 because of the styles migration where tabOpacity function is updated to return an object.

It used to return just a number and that value was set for the opacity prop but now we are trying to set an object for the opacity prop.

Example of TabLabel and TabIcon:

App/src/components/TabSelector/TabLabel.js

Lines 28 to 31 in fe282b4

	<Animated.View style={[{opacity: activeOpacity}]}>
	<Text style={styles.tabText(true)}>{title}</Text>
	</Animated.View>
	<Animated.View style={[StyleSheet.absoluteFill, {opacity: inactiveOpacity}]}>

App/src/components/TabSelector/TabIcon.js

Lines 29 to 35 in fe282b4

	<Animated.View style={{opacity: inactiveOpacity}}>
	<Icon
	src={icon}
	fill={themeColors.icon}
	/>
	</Animated.View>
	<Animated.View style={[StyleSheet.absoluteFill, {opacity: activeOpacity}]}>

What changes do you think we should make in order to solve the problem?

Pass the opacity object(activeOpacity, inactiveOpacity) directly to TabLabel and TabIcon components.

App/src/components/TabSelector/TabLabel.js

Line 28 in fe282b4

<Animated.View style={[{opacity: activeOpacity}]}>

would become:

<Animated.View style={[activeOpacity]}>

Suggesting this because we're already using an object for tabBackground function.

Will also update the default prop values to empty objects here:

App/src/components/TabSelector/TabLabel.js

Lines 19 to 23 in fe282b4

	const defaultProps = {
	title: '',
	inactiveOpacity: 1,
	activeOpacity: 0,
	};

[Pujan92]

Same RCA with #29602 (comment)

[kubabutkiewicz]

Created PR per request from @situchan

[mountiny]

The pr author resolved this, thanks!

[strepanier03]

@mountiny - Can we close this or do we owe money to someone? I'm not 100% sure but it looks like perhaps this can just be closed.

[namhihi237]

I am reporter. I think i am able receive a bonus

[mountiny]

@strepanier03 yeah I think we only need to pay the reporter @namhihi237 $50 thank you!

[melvin-bot]

This issue has not been updated in over 15 days. @strepanier03 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[namhihi237]

Hi @strepanier03 @mountiny Any update payment for this

[mountiny]

Sorry the automation failed I have updated this

[melvin-bot]

@strepanier03 Eep! 4 days overdue now. Issues have feelings too...

[strepanier03]

My apologies for the delay here, I was out of the office last week for the US holiday. I'll work on moving this forward now.

[strepanier03]

@namhihi237 - I've sent the offer and will check this later today to pay out.

[namhihi237]

@strepanier03 thanks. accepted

[strepanier03]

All right, paid out via Upwork and contract closed. Pretty sure this is good to close so going to do that. Feel free to reopen if I did that too soon.